Comments (4)
i agree it's the right thing to do. maybe we can get dsub to respect originalReleaseDate in the far future
from gonic.
i see. i definitely prefer the current behaviour personally. when i look at an artists discography i'd like to see it in chronological order, regardless of when a particular reissue or remaster came out. and legacy clients only look at the "year" field
but i see the point. you propose that we make gonic's current year
to be originalReleaseDate
, and year
be the edition year
we can do that, just unfortunate that clients like dsub will show artist's discographies in a weird order (assuming no config option, which i'd rather not add)
from gonic.
The main issue with the current behavior is that it forces a certain behavior without allowing the alternative.
If year
would return the year
like it used to, users who want to use original years can do so by simply setting it to the original year.
Now that year
returns original_year
, to get gonic to return me the original year
, I can either:
- delete
original_year
from the tags, thus losing information - swap the values of
original_year
andyear
, which is quite silly
I can see why you'd want to avoid introducing a config option for such a small change, but I wouldn't call it "weird order", for some people, that is the correct order :)
If you want to keep the current behavior, I can patch it out locally, just thought that now that opensubsonic exists, it might be nice to use some of the features.
from gonic.
Great, let me know if you'd like help implementing/testing it.
from gonic.
Related Issues (20)
- getPlaylist endpoint returning object that is missing the 'changed' field
- stream_id in Podcast object is used differently from Subsonic HOT 5
- Playlist object is missing required 'duration' field HOT 1
- gonic doesn't return playcounts in album response HOT 2
- feat: song level play counts HOT 3
- API Qestion (Not a real bug) HOT 1
- FR: Redownload existing podcast episodes HOT 4
- feat: try all tracks in dir for album metadata instead of first
- Transcoding seemingly does nothing HOT 3
- CreatePlaylist api response sends blank/empty playlist ID
- Intelligent track change detection in scanner to preserve primary keys HOT 2
- Empty "Unknown Album" HOT 8
- taglib v2 downstream HOT 6
- feature: Include genre and album's date/year in listenbrainz scrobble payload HOT 3
- Last.fm Artist Lookup not sanitizing special characters in Artist's names HOT 4
- Genre split and podcast download issue HOT 12
- Search Album by Name doesn't fetch all results HOT 1
- feat: Add support for Artist Sort Name HOT 1
- Scan HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gonic.