Giter Club home page Giter Club logo

Comments (4)

sentriz avatar sentriz commented on June 20, 2024 1

i agree it's the right thing to do. maybe we can get dsub to respect originalReleaseDate in the far future

from gonic.

sentriz avatar sentriz commented on June 20, 2024

i see. i definitely prefer the current behaviour personally. when i look at an artists discography i'd like to see it in chronological order, regardless of when a particular reissue or remaster came out. and legacy clients only look at the "year" field

but i see the point. you propose that we make gonic's current year to be originalReleaseDate, and year be the edition year

we can do that, just unfortunate that clients like dsub will show artist's discographies in a weird order (assuming no config option, which i'd rather not add)

from gonic.

autrimpo avatar autrimpo commented on June 20, 2024

The main issue with the current behavior is that it forces a certain behavior without allowing the alternative.

If year would return the year like it used to, users who want to use original years can do so by simply setting it to the original year.
Now that year returns original_year, to get gonic to return me the original year, I can either:

  • delete original_year from the tags, thus losing information
  • swap the values of original_year and year, which is quite silly

I can see why you'd want to avoid introducing a config option for such a small change, but I wouldn't call it "weird order", for some people, that is the correct order :)

If you want to keep the current behavior, I can patch it out locally, just thought that now that opensubsonic exists, it might be nice to use some of the features.

from gonic.

autrimpo avatar autrimpo commented on June 20, 2024

Great, let me know if you'd like help implementing/testing it.

from gonic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.