Giter Club home page Giter Club logo

Comments (4)

sentriz avatar sentriz commented on June 20, 2024

i'm not entirely sure about returning albums based on artist appearances. maybe it's redudant if we already update to search artist by artist? in most clients you can click on the relevant album from the track results.

for example i search for artist X who only appears on a compilation album, see the track in the track list, click on the track's album

from gonic.

ry-gon avatar ry-gon commented on June 20, 2024

My reasoning for including the albums is that there's no existing way to list all the albums for an appearing artist (as you'd normally see on a regular artist view), and it can be quicker to find the right album by recognizing the art, or just be more convenient to browse if you've forgotten which albums that artist appeared on. Seeing a track in the track list and going to the album from there does work fine, but on clients like e.g. DSub the track list doesn't include any information on what that album is (without an extra two clicks to show details) so it might take a few tries to find the album you're looking for.

I think it provides value, but can see how it might clutter the results a bit

from gonic.

sentriz avatar sentriz commented on June 20, 2024

hey, i just got around for trying this out for a couple days. and at least to my taste and library, the search is too cluttered to find anything. i think i'd close this for now. but i am still not opposed to futher changes

perhaps something like search both track & artist fields for the tracks results (maybe only matching on artist when that artist is a track-only artist such as compilation albums)

on top of that it should be the clients resposibilty to generate a clickable link back to the album - like how airsonic-refix does

thanks!

from gonic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.