Comments (11)
is your popup in the same session as where the extension is loaded?
from electron-extensions.
I think so, yeah.
Here's where I'm setting the partition: https://github.com/RangerMauve/agregore-browser/blob/master/app/extensions/index.js#L48
Here's where I'm using the partition for the web contents: https://github.com/RangerMauve/agregore-browser/blob/master/app/ui/index.html#L25
It looks like the content scripts from plugins are being injected just fine. 🤔
from electron-extensions.
Any errors in the background page webcontents?
from electron-extensions.
Hey! Thanks for the follow up, I had to focus on other stuff for a while, just getting back into this.
It seems that it's having issues with getting the active tab URL. It looks like the action popups might be spawning correctly, but I'm not sure how the active tab stuff would work here. 🤔
from electron-extensions.
I'm adding all the windows with extensions.addWindow
Could the sandboxing be preventing necessary IPC messages or something?
from electron-extensions.
I think not, but I'm not sure
from electron-extensions.
What's actually preventing you from using the new version of this lib?
from electron-extensions.
I think maybe docs? I tried upgrading earlier and I could get anything to work anymore. 😅
I could try again some time soon.
So far I'm thinking it's a race condition where when I click on the action, the BrowserView containing the web content loses focus and therefore there's no longer an active tab to query.
from electron-extensions.
Err, it doesn't look like the activeTab variable is getting set anywhere? I'll see if that's the issue and maybe I could submit a PR to fix it if that's the case?
from electron-extensions.
Oh, you should set session.activeTab
property to the corresponding web contents id by yourself.
from electron-extensions.
It worked! Thank you so much. 😁
I'll submit a PR to the 6-x-y branch with some docs on the activeTab portion. 💜
from electron-extensions.
Related Issues (20)
- Skipping extension with invalid URL HOT 1
- Write tests
- adding crx HOT 2
- Tracking issue for Chrome APIs HOT 2
- objectToArray function mangles requestHeaders and responseHeaders HOT 1
- Does it work with content scripts that do not run in background page? HOT 4
- Question: Can we load extensions from Web Stor? HOT 1
- Status of electron 9 support HOT 1
- Known supported extensions HOT 2
- electron-extensions 7.0.0 HOT 4
- windows.create in background page HOT 1
- UnhandledPromiseRejectionWarning: TypeError: Cannot redefine property: webRequest
- Active loaded extension HOT 13
- Unable to load ublock origin HOT 4
- chrome.tabs.getSelected() should not return an array on 7.0.0-beta.2 HOT 1
- What does the License Mean? HOT 1
- Support promise responses in WebRequest
- Cannot use import statement outside a module HOT 1
- Using PDF.JS as Chrome Extensions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-extensions.