How to properly open windows for browser Action popups about electron-extensions HOT 11 CLOSED

is your popup in the same session as where the extension is loaded?

from electron-extensions.

I think so, yeah.

Here's where I'm setting the partition: https://github.com/RangerMauve/agregore-browser/blob/master/app/extensions/index.js#L48

Here's where I'm using the partition for the web contents: https://github.com/RangerMauve/agregore-browser/blob/master/app/ui/index.html#L25

It looks like the content scripts from plugins are being injected just fine. 🤔

from electron-extensions.

Any errors in the background page webcontents?

from electron-extensions.

Hey! Thanks for the follow up, I had to focus on other stuff for a while, just getting back into this.

It seems that it's having issues with getting the active tab URL. It looks like the action popups might be spawning correctly, but I'm not sure how the active tab stuff would work here. 🤔

from electron-extensions.

I'm adding all the windows with extensions.addWindow

Could the sandboxing be preventing necessary IPC messages or something?

from electron-extensions.

I think not, but I'm not sure

from electron-extensions.

What's actually preventing you from using the new version of this lib?

from electron-extensions.

I think maybe docs? I tried upgrading earlier and I could get anything to work anymore. 😅

I could try again some time soon.

So far I'm thinking it's a race condition where when I click on the action, the BrowserView containing the web content loses focus and therefore there's no longer an active tab to query.

from electron-extensions.

Err, it doesn't look like the activeTab variable is getting set anywhere? I'll see if that's the issue and maybe I could submit a PR to fix it if that's the case?

from electron-extensions.

Oh, you should set session.activeTab property to the corresponding web contents id by yourself.

from electron-extensions.

It worked! Thank you so much. 😁

I'll submit a PR to the 6-x-y branch with some docs on the activeTab portion. 💜

from electron-extensions.