Giter Club home page Giter Club logo

Comments (12)

dorianpb avatar dorianpb commented on June 2, 2024 1

For both of the mods, I initially used mmm install, but then tried downloading manually and using mmm update. The exact command I used to try downloading enhanced block entites was mmm install enhancedblockentities=modrinth:ebe, and for cem it was mmm install cem=curse:custom-entity-models-cem

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024 1

Hi @cobalt2727, this issue hasn't been solved yet. There hasn't been as much development on mcman as I hoped. IRL stuff and a bit of coding burnout from having coding as my work as well.

For now, the only thing is to update this manually. I know it's a hassle (since I also have to do this for some mods I personally use), but at least better than having to download all manually.

Since it's a tricky one to solve thanks to curse search is a bit weird.

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024 1

Found it 🙂
https://github.com/TimKam/compound-word-splitter

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024

I briefly looked into this since it seemed weird.

Apparently, it's CurseForge's unofficial API that doesn't work as I expected. If I search on entityculling it doesn't find it, even though the slug is called entityculling. But if I search on entity culling it shows up as one of the results... This could be a tricky one to solve... Unless there is an option that I'm missing, which there could be since it's not a documented API.

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024

Doesn't seem to be an option I'm missing. Searching for entityculling on CurseForge returns the same result (No mods found).

I'd mostly say the responsibility is on CurseForge, but I'll try to fix it somehow.

There is a python library called compound-word-splitter which would split the word entityculling into entity culling. However, it needs enchant to be installed on the computer (a third-party library) and only works on Unix-like systems.

from minecraft-mod-manager.

dorianpb avatar dorianpb commented on June 2, 2024

This has been happening to me, too, with custom entity models and enhanced block entities, among others. Offering the slug doesn't help.

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024

@dorianpb This information (mods that it can't find) will be very helpful with fixing this behavior 🙂

I have some additional questions that can help me pinpoint the issue (and make sure I fix it). Did you use mcman install command, or had you installed them manually and then used mcman update?

I'm seeing that enhanced block entities are actually from modrinth, they have a better search engine than CurseForge. Could you supply the exact command you used to install/update enhanced block entities?

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024

Thanks a lot 😃 I have some ideas on how to solve this issue, it's not really a good solution since it uses brute force. I have another solution that requires me to implement and publish a service that splits the single word into multiple ones.

I just also got an idea for displaying some options if there are no matches. For example:

No matches found for enhancedblockentities. Does any of these match?
1. enhanced block entities
2. enhanced mobs
3. block entities enhanced
Select mod by entering the number, or just press enter to continue without installing this.

from minecraft-mod-manager.

cobalt2727 avatar cobalt2727 commented on June 2, 2024

This still happens for me, did anyone have any ideas?

from minecraft-mod-manager.

cobalt2727 avatar cobalt2727 commented on June 2, 2024

No worries. Thanks for the response!

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024

Some updates on this issue.

I found this site (https://www.modpackindex.com/mods) which indexes mods from curse forge. This can be of use since the search here seems to be a lot better than the one at curse. Not sure if this is sufficient though, or if I should create my own indexer service later down the line.

I did find a library that could split words. However, I forgot to comment the library here; hopefully, I can find it again 😅 But I think this will be the next task I'll work on, trying to fix all the search issues.

from minecraft-mod-manager.

Senth avatar Senth commented on June 2, 2024

Fixed the issue now and tested with entityculling so it seems to work fine 🙂

Will be released as part of v1.3.0 🎉

from minecraft-mod-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.