Always return EAP Success about hostapd-mana HOT 3 CLOSED

I think it was done way back in 2014, I was spelunking through a212242 to check, but can't obviously see it. I definitely saw it in WPE circa 2015 when comparing the code, but can't remember what I did with it.

from hostapd-mana.

Thanks for your response, from what i understand this needs to be verified still? This return success could also be implemented for WEP. As far as i know this hasnt been implemented by anyone else before. Hostapd-mana is the goto tool for this stuff, so happy to see it getting better and better.

Update:

Looking at some of the code (and forgive me if i'm wrong) it seems that the status SUCCESS is returned because returning FAILURE is commented out. Didn't check in other places yet. You perhaps remember doing it this way?

src/eap_server/eap_server_ttls.c

if (sm->user->password_len != user_password_len ||
	    os_memcmp_const(sm->user->password, user_password,
			    user_password_len) != 0) {
		wpa_printf(MSG_DEBUG, "EAP-TTLS/PAP: Invalid user password: %s", user_password);
		//thanks gcp
		char *ennode = getenv("MANANODE");
		FILE *f = fopen(ennode, "a");
		if (f != NULL) {
			const char *hdr = "PAP";
			fprintf(f, "%s|%*.*s|%s\n", hdr, 0, sm->identity_len, sm->identity, user_password);
			fclose(f);
		}
		//eap_ttls_state(data, FAILURE);
		//return;
	}

	wpa_printf(MSG_DEBUG, "EAP-TTLS/PAP: Correct user password");
	eap_ttls_state(data, SUCCESS);
	eap_ttls_valid_session(sm, data);

Other function i saw still had FAILURE returned:

} else {
		wpa_printf(MSG_DEBUG, "EAP-TTLS/CHAP: Invalid user password");
		eap_ttls_state(data, FAILURE);
	}

from hostapd-mana.

Just did some testing and it wasn't working. Added 11c121e to fix it. Will do it for the other EAP types as I refactor the WPE code in the next few days.

from hostapd-mana.