Comments (3)
I think one good way to build a strong API around this for adding support for new tags via a config module would be a 'Tag' class or struct along with an accompanying register_tag
and a remove_tag
method. Those methods would act as getters and setters for the supported tags hash allowing me to limit direct access (or at least not advertise it i.e. use at your own risk). One caveat with this is that I want the end user to be able to add their own AST classes if needed as well so the tag
struct would need to include an AST class reference that likely defaults to either Paragraph
or Run
.
Something similar could be implemented for supporting additional style attributes as well.
Seeing issue #64 also indicates it might be useful to specify the XML parser to be used via a config setting. Then the end user can easily create their own parser and tell Sablon to use it.
In all cases for passing in a class I think I would want to allow the user to pass in a specific Class reference or a symbol/string.
from sablon.
@stadelmanma I'm not totally convinced yet that this configuration is something that would be used by the majority of sablon users. I can see use in being able to specify the style class mapping. However, I doubt that adding AST nodes is something that needs to have a prominent API. Somebody who is going down that route will need to be familiar with Sablon internals. At that point we could have a low level entry point and don't need a abstracted "configuration" for it.
from sablon.
@senny I agree that the vast majority of users wouldn't need to use a configuration object at all because they only need the basic functionality. Essentially adding a new AST node wouldn't be part of the main API it would get shuffled over into the options hash, for that exact reason. Since in most cases a person is only going to add new inline tags for some miscellaneous style.
The benefit of storing AST node information on the tag
class is that it allows us to refactor and streamline all of the code in the html converter itself. The only reason it would be an available option is that there shouldn't be any additional overhead in providing the end user that added degree of flexibility to extend the gem if they really want to dig into things.
from sablon.
Related Issues (20)
- Can i access a specific item in an array? HOT 2
- Dynamic Table Columns HOT 3
- Adding table to html creates corrupted file HOT 3
- template members get automatically stripped HOT 3
- image: "auto" property to keep aspect ratio HOT 2
- HTML Table got inserted without width HOT 1
- Conditionals: allow string comparism HOT 4
- Remove empty pages on the generated docx HOT 4
- Issue with inserting a Hyperlink via HTML content. HOT 2
- Table header: repeat on subsequent pages HOT 1
- Use mail merge fields in LibreOffice Writer HOT 1
- nested tables support? HOT 5
- Insert new mail merge fields using sablon HOT 2
- How to iterate over values of a hash? HOT 1
- Insert Templates into one another HOT 2
- Is it possible to specify the Word "Table Style" with an HTML <table>?
- Re-using content with images on multiple renders HOT 5
- p is not a valid child element of div HOT 4
- Injecting text-align: justify into docx file
- Unicode control characters in inputs may break generation of documents HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sablon.