Calculations not triggered in manage results view about senaite.core HOT 12 CLOSED

Proper description. Calculations seem to be not triggered by result entry.
But calculations within an AS triggered by interim fields are working correctly.

from senaite.core.

The demo at senaite.ridingbytes.com also shows a defective calculation currently.
See simple Total Hardness Calc (e.g. H2O-0004-R01).

from senaite.core.

Maybe a duplicate of bikalims/bika.lims#2202?

from senaite.core.

I tried to reproduce this issue but it seems to me that it is working as expected. I am attaching two images to demonstrate that, one image was taken using senaite.lims, and the other one using bika.lims alone. I also reproduced the same steps uing both browsers, firefox and chrome.

@ramonski Should we close this issue, or am I missing some steps you did?

from senaite.core.

Thanks @Espurna, please don't close it yet until we got the feedback from @grulisco.

It seems that this also happens on https://senaite.ridingbytes.com/clients/client-6/H2O-0004-R01/manage_results (labman1:labman1).

@grulisco could you please check if this setup I described in this issue actually reproduce the behavior on your server or did I miss something?

from senaite.core.

Please keep it open.
See https://senaite.ridingbytes.com/clients/client-6/H2O-0004-R01/manage_results:

Simple addition does not work.

The testcase (length, width, ...) described is translated from my setup correctly, and still does not work properly.

from senaite.core.

still a problem with senaite 1.1.6

from senaite.core.

Although the problem persists in old Analysis Requests, it works as expected when creating new Analysis Requests. I've tested the instance after the upgrade 1.6.6. @grulisco can you confirm that if you create a new Analysis Request and select the same analyses, this issue does not happen?

Technical overview
To obtain the analyses to which a given analysis depends on to calculate its result, ultimately relies on calculation.getDependentServices function. And here is the problem: DependentServices field from Calculation was changed from a HistoryAwareReferenceField to an UIDReferenceField on Nov 2. The instance you are using was probably updated after this commit and this relationship was lost.

from senaite.core.

@xispa I'm still on 1.1.6 :) But, in my instance calculations still are not triggered even with new ARs.
(same in senaite.ridingbytes...)
Expecting latest update by @ramonski tomorrow...

from senaite.core.

@grulisco can you try to go to Kantenlaengen's calculation view and press the save button first. After that, try to create a new AR

from senaite.core.

@xispa Yes it does work, after updating the calculations!
So it seems, that this issue affects not only old ARs but old calcultations too...

from senaite.core.

I've done some modifs to the upgrade step 1.1.6 to deal with those broken calcs in Analyses from old Analysis Requests that were not using the latest version of Calculation in #403 , so rerunning 1.1.6 will make the calculations work in old ARs too.

from senaite.core.