Giter Club home page Giter Club logo

Comments (10)

ovlb avatar ovlb commented on July 23, 2024 1

I think this a good solution for right now. I have a feeling I'm missing some edge cases right now

There will be edge cases :D We will fix them once they poke us too hard.

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

Agree with this change for sure! It was always the hope that the site would grow. šŸ¤— (tries not to get weird and emo)

We should be mindful though of future linking strategies when coming up with the canonical link. For example, one hope is to be able to concatenate terms so someone can theoretically link to serve up a page that shows all the terms they identify as:

?queer+disabled+wheelchair-user
Full context and discussion here: #6

So, tl;dr, let's do it, as long as we feel confident the above scenario can be addressed as we start to look at broader database needs

from web-app.

ovlb avatar ovlb commented on July 23, 2024

Yip. The combined pages are definitely a part of it. I think they might even become simpler once we have these detail pages, as we can already start defining a layout :)

My reasoning for /definitions/word is that the homepage might change in the future and become more of an overview introducing the whole project with its bots, API and so forth. By having an URL scope for the definitions we avoid dealing with redirects in the future when we might want to have the API info page at /api.

Is it okay if I take this issue?

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

Yes, awesome, I'm so glad you're such a holistic thinker! šŸ¤—

Also I should add that we need to create redirects as there are some links out in the world already for /#word. Should I open up a new issue for this?

from web-app.

ovlb avatar ovlb commented on July 23, 2024

I think thatā€™s an acceptance criteria for closing this issue.

Iā€™ll add a to-do list to the OP asap to make the scope of this issue clearer. :)

from web-app.

ovlb avatar ovlb commented on July 23, 2024

@tatianamac Iā€™ve added a to-do list. Anything else that comes to mind?

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

Looks good!

What is the intention of next/last links? Do they link to the next and previous words alphabetically? I worry a bit about what we mean by this when we consider sub-terms would theoretically appear twice in the full list, if that makes sense.

(For example, cis appears both under C (cis) and G (cisgender).)

from web-app.

ovlb avatar ovlb commented on July 23, 2024

I thought it is a nice touch for the page, to encourage browsing around. Probably have thought about it because I like the game Ā«open a dictionary and read whatever words show upĀ» so much. The Duden (german dictionary) has a similar feature at the bottom of their definition pages: https://www.duden.de/rechtschreibung/Geviert

Random feature idea: A Ā«Show me a random definitionĀ»-button on the homepage.

from web-app.

ovlb avatar ovlb commented on July 23, 2024

One solution for the sub-terms might be to include only the main term Ā«genderĀ» while somewhere around Ā«geĀ» and cisgender while browsing around Ā«ciĀ». In any way, cisgender will be shown in the sub-terms of gender on the detail page of gender.

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

I think this a good solution for right now. I have a feeling I'm missing some edge cases right now

One solution for the sub-terms might be to include only the main term Ā«genderĀ» while somewhere around Ā«geĀ» and cisgender while browsing around Ā«ciĀ». In any way, cisgender will be shown in the sub-terms of gender on the detail page of gender.

from web-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.