Giter Club home page Giter Club logo

Comments (8)

MatthewShields avatar MatthewShields commented on July 23, 2024

@tatianamac I can take a look at this one :) just to check a couple of things though:

  1. alongside the adding of the note to the individual definition page, because you have mentioned the homepage looking cluttered would you want them removing from the homepage?

  2. if this is the case would you want to keep the other homepage red flags such as racist or sexist terms?

from web-app.

MatthewShields avatar MatthewShields commented on July 23, 2024

I have approached it like this, however as this has involved design decisions it would be good to get your input as I don't want to mess with the aesthetic of the site.

I have added an introductory section (when a flag is present) with an anchor link to a section at the bottom. My thought process on this was that it would allow the guidance on content warnings to be expanded if necessary without disrupting the definition content.

Screenshots

Top:
image

Bottom:
image

There is the capability to have separate flag content between the amber and red level definitions.


Selection styling

I have also added selection styling to the .box class incase someone ever needs to copy content from the content warning guidance:

image

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

Hi @MatthewShields ! This is awesome, thank you so much for taking a pass at this!

I'd love to see a few things for if/when you decide to open a pull request:

  • Integrate the content warning style (yellow instead of red, with the ⚠️ iconography) into the top and bottom boxes (so light yellow background on both, perhaps with that red line to yellow?
  • I think that the "Content warning: [topic]" sentence could use a little work (which is my bad). Perhaps it reads" "Content warnings usually take the form of "Content warning: [topic(s)]" or "CW: [topic(s)]. We recommend the former when possible.

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

As for your questions, I think that at some point, we'll probably no longer have this "all words" view, and the homepage will function a bit more as a explainer as to what this tool is, and perhaps we'll have all the tags linked under a "avoid terms" list. Until then, I think it's good to keep them as a cursory glance; the content warning just sent it a bit over the visual overload edge.

from web-app.

MatthewShields avatar MatthewShields commented on July 23, 2024

Great thanks for the input will get onto working on the changes now :)

Will keep the flags on the homepage but if you want an extra set of hands in the future working on that feel free to @ me.

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

I always appreciate extra help! Also, I have opened up Self-Defined Saturdays on Slack so folks can get input and collaborate (and I can offer centralised, immediate help), if you'd like to join!

from web-app.

MatthewShields avatar MatthewShields commented on July 23, 2024

@tatianamac I think we can mark this issue as closed now?

from web-app.

ovlb avatar ovlb commented on July 23, 2024

@MatthewShields I’ve linked the PR so that both open issues get auto-closed.

from web-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.