Giter Club home page Giter Club logo

Comments (7)

tatianamac avatar tatianamac commented on July 23, 2024

Hi @zackkrida ! Thanks for filing this issue! I'd love if you could submit a PR!

from web-app.

HarshKapadia2 avatar HarshKapadia2 commented on July 23, 2024

@tatianamac I fixed this issue locally by making an addition to ./dist/assets/css/base.css, but whenever I run npm run build, the changes vanish for some reason and Git does not record any changes that I made. When I run npm run serve again, the code is back to its original state, ie, without my changes in base.css. Could you please tell me what I am doing wrong?

from web-app.

ovlb avatar ovlb commented on July 23, 2024

@HarshKapadia2 ./dist is the build folder, which gets overwritten every time you run a build. The source files are located in ./assets/css/. You’ll probably find the correct file there.

If you want to inspect your changes locally you can use npm run serve. :)

from web-app.

HarshKapadia2 avatar HarshKapadia2 commented on July 23, 2024

Thank you for the reply @ovlb!
I'll make a PR soon!

from web-app.

zackkrida avatar zackkrida commented on July 23, 2024

@HarshKapadia2 thank you for handling that; looks great!

from web-app.

HarshKapadia2 avatar HarshKapadia2 commented on July 23, 2024

No problem and thank you @zackkrida!

from web-app.

tatianamac avatar tatianamac commented on July 23, 2024

Thank you for filing the issue, @zackkrida and for jumping on it, @HarshKapadia2 ! I appreciate you both!

Closing this issue manually since I don't think GH allows backwards PR-issue linking 🙃

from web-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.