Comments (14)
Do we have access to modify seleniumbase requirements.txt? In a way, we can modify it and make sure the fix works on our own. We have our own requirements.txt, where we had the latest version of urllib3 and it worked. If we can modify seleniumbase requirements.txt, we are not blocked until you fix requirements.txt.
from seleniumbase.
Hi @himasimplisafe , looks like they just released urllib3 1.25 . I will ship a SeleniumBase update in 9 hours when I get back to my computer. In the meantime, you can update your requirements.txt file to allow the version you need.
from seleniumbase.
It is good to know that there is python requests library https://github.com/kennethreitz/requests/pull/5063 fix is also in progress. So if you update urllib3 to 1.25, it is not going to work until https://github.com/kennethreitz/requests/pull/5063 is merged.
from seleniumbase.
That’s the main reason I lock down urllib3 and requests versions: They don’t always play nice with each other.
from seleniumbase.
Since you are already locked down requests and urllib3 versions, seleniumbase should go ahead with the versions you had in requirements.txt right, not sure why pkg version conflict with urllib3? Can you please explain?
from seleniumbase.
Does the same situation happen for you in a python virtual environment?
from seleniumbase.
For my local python virtual environment, I am not seeing issue using latest urllib3 version. But on CI(we use bees) only, I am seeing issue.
from seleniumbase.
A more permanent solution would be for me to remove urllib3 from the requirements and to try using requests for everything instead. I think I only use urllib3 for chomedriver and other driver installation.
from seleniumbase.
Once you remove urllib3 from requirements, we could run our tests again. Thanks
from seleniumbase.
Due to: requests 2.21.0 has requirement urllib3<1.25,>=1.21.1, but you'll have urllib3 1.25 which is incompatible.
I can't remove urllib3 unless requests removes their requirement of urllib3.
I'm finding a workaround right now.
from seleniumbase.
I am still confused that why seleniumbase has issues with urllib3 version 1.25, since you have hardcoded requests 2.21.0 and urllib3 1.24 versions.
from seleniumbase.
@himasimplisafe Try with the newly released seleniumbase 1.23.4
from seleniumbase.
Once requests
updates their requirements to allow the latest urllib3
, I'll update again.
from seleniumbase.
urllib3 recently released https://github.com/urllib3/urllib3/releases/tag/1.24.3 , which patches a major issue. (Their newest versions have been 1.25.x up until now). Since requests
is now in maintenance mode (according to https://github.com/kennethreitz/requests/blob/master/docs/index.rst , it is unlikely that they'll support the urllib3 1.25.x series any time soon. Therefore SeleniumBase will hardcode urllib3 version 1.24.3 for now. No issues detected with SeleniumBase so far, and now there are no more urllib3 conflicts. Closing this ticket.
from seleniumbase.
Related Issues (20)
- UC Mode's `driver.uc_click(selector)` isn't properly escaping selectors that contain quotes HOT 1
- Unable to pass cloudflare using UC Mode HOT 2
- Integrate Type Checks, to improve development experience. HOT 1
- Maintainer away for 3 days. Hold your questions until April 10. HOT 2
- Comparison between playwright and seleniumbase? HOT 4
- Is it possible to add selenum webdriver remote with seleniumbase. HOT 1
- How to add saved cookies to a new browser HOT 2
- Browser asks for SSL authentication in Selenium Grid. HOT 3
- When the previous step page is not yet fully loaded, the self. open() of the next step has already been run directly HOT 2
- I hope this script can use the previous browser HOT 11
- Unable to record keystrokes
- Can't pass bot detection on dexscreener.com on Linux HOT 7
- Add UC Mode `driver` methods directly into the `SB` API HOT 1
- Some elements cannot be inputted using the input method HOT 1
- Session Time Out while trying to spawn broswer in Docker HOT 1
- Timezone problem on pixelscan test HOT 2
- Failing Docker tests when running on M2 mac HOT 4
- Docker overhaul needed HOT 2
- Encountered InvalidSessionIdException occasionally in local docker run HOT 6
- Freezes on ChromeOS when loading Driver HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seleniumbase.