Giter Club home page Giter Club logo

Comments (14)

himasimplisafe avatar himasimplisafe commented on May 21, 2024

Do we have access to modify seleniumbase requirements.txt? In a way, we can modify it and make sure the fix works on our own. We have our own requirements.txt, where we had the latest version of urllib3 and it worked. If we can modify seleniumbase requirements.txt, we are not blocked until you fix requirements.txt.

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

Hi @himasimplisafe , looks like they just released urllib3 1.25 . I will ship a SeleniumBase update in 9 hours when I get back to my computer. In the meantime, you can update your requirements.txt file to allow the version you need.

from seleniumbase.

himasimplisafe avatar himasimplisafe commented on May 21, 2024

It is good to know that there is python requests library https://github.com/kennethreitz/requests/pull/5063 fix is also in progress. So if you update urllib3 to 1.25, it is not going to work until https://github.com/kennethreitz/requests/pull/5063 is merged.

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

That’s the main reason I lock down urllib3 and requests versions: They don’t always play nice with each other.

from seleniumbase.

himasimplisafe avatar himasimplisafe commented on May 21, 2024

Since you are already locked down requests and urllib3 versions, seleniumbase should go ahead with the versions you had in requirements.txt right, not sure why pkg version conflict with urllib3? Can you please explain?

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

Does the same situation happen for you in a python virtual environment?

from seleniumbase.

himasimplisafe avatar himasimplisafe commented on May 21, 2024

For my local python virtual environment, I am not seeing issue using latest urllib3 version. But on CI(we use bees) only, I am seeing issue.

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

A more permanent solution would be for me to remove urllib3 from the requirements and to try using requests for everything instead. I think I only use urllib3 for chomedriver and other driver installation.

from seleniumbase.

himasimplisafe avatar himasimplisafe commented on May 21, 2024

Once you remove urllib3 from requirements, we could run our tests again. Thanks

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

Due to: requests 2.21.0 has requirement urllib3<1.25,>=1.21.1, but you'll have urllib3 1.25 which is incompatible. I can't remove urllib3 unless requests removes their requirement of urllib3.
I'm finding a workaround right now.

from seleniumbase.

himasimplisafe avatar himasimplisafe commented on May 21, 2024

I am still confused that why seleniumbase has issues with urllib3 version 1.25, since you have hardcoded requests 2.21.0 and urllib3 1.24 versions.

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

@himasimplisafe Try with the newly released seleniumbase 1.23.4

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

Once requests updates their requirements to allow the latest urllib3, I'll update again.

from seleniumbase.

mdmintz avatar mdmintz commented on May 21, 2024

urllib3 recently released https://github.com/urllib3/urllib3/releases/tag/1.24.3 , which patches a major issue. (Their newest versions have been 1.25.x up until now). Since requests is now in maintenance mode (according to https://github.com/kennethreitz/requests/blob/master/docs/index.rst , it is unlikely that they'll support the urllib3 1.25.x series any time soon. Therefore SeleniumBase will hardcode urllib3 version 1.24.3 for now. No issues detected with SeleniumBase so far, and now there are no more urllib3 conflicts. Closing this ticket.

from seleniumbase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.