Comments (6)
ukclivecox
commented on September 24, 2024
This sounds like a useful enhancement. Can you explain more the issue and are you able to provide a PR (maybe just docs) to illustrate the fix?
from seldon-operator.
fico-jessecarroll
commented on September 24, 2024
Sure. I'll try to find some time today or early next week. The work-around policy manifest is fairly straight forward.
apiVersion: "authentication.istio.io/v1alpha1" kind: "Policy" metadata: name: "default" spec: peers: - mtls: mode: PERMISSIVE
This I found needs to be applied in the namespace of seldon and the namespace where the model is deployed, otherwise, the pod of the model reports a 503. I have't had time to dig into debugging the istio-proxy sidecar.
from seldon-operator.
fico-jessecarroll
commented on September 24, 2024
Created a pull request. Have you 'merged' this into core? If so, i can create pull request for that as well if you approve this.
Thanks
from seldon-operator.
ukclivecox
commented on September 24, 2024
Yes. Would be great to open on there.
from seldon-operator.
ukclivecox
commented on September 24, 2024
Will this be ok for users who don't want mTLS?
from seldon-operator.
fico-jessecarroll
commented on September 24, 2024
I'll open an issue in the seldon-core project and put in a pull request.
So I tested both permissive and strict mTLS and this seems to work with both. You and your team are obviously free to test/verify, catch any usecase I might have missed.
Thanks
from seldon-operator.
Related Issues (17)
- Go-operator needs to have Kubernetes like APIs for Seldon Deployments
- Add KO integration for development
- TLS Errors in logs HOT 2
- Add kubebuilder mark for seldondeployments/finalizers HOT 2
- Missing release version
- Volumes causing deployment updates
- Update TFProxy Server to tfserving-proxy:0.5 image (from 0.3) HOT 1
- Change Kustomize folders to work with v2
- validating webhook should check for container name
- Seldon controller does not create Ambassador REST config if a non PU container exists HOT 4
- prepackaged servers: Tensorflow serving: ability to override only part of containers
- Delete hpaSepc in seldon deployment doesn't delete the hpa object. HOT 3
- Timeout annotations are not respected when calling REST endpoint within Istio env HOT 1
- initContainer tfserving-model-initializer is not able to pull model from s3 HOT 1
- Operator projects using the removed APIs in k8s 1.22 requires changes.
- Operator projects using the removed APIs in k8s 1.22 requires changes. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seldon-operator.