CI action repo checkout python script get-prs can't find github module about sel4bench HOT 3 CLOSED

Seem we need a dedicated docker container for ci-actions/repo-checkout that has PyGithub. I wonder if a generic docker base container for all github ci actions build from "trustworthysystems/sel4:latest + PyGithub" makes sense, something like trustworthysystems/sel4-github-ci"

from sel4bench.

This is extremely strange, I'll look into it. We have seen the test-with feature working fine all this time, so something must be going on.

A generic base image for all actions doesn't make sense:

• not all actions run in containers
• they have many different base dependencies (even different linux distributions)

That is also why there is a scripts directory, because those scripts can be shared over different images and without docker. They do need their dependencies satisfied, of course, but that is what the setup phase is for that almost all the actions have.

from sel4bench.

Ok, I figured it out: surveying the workflows so far, we haven't actually used the repo-checkout action for pull requests yet, so the code that needs that dependency was not executed there. We only need it if we want to chain multiple actions together and that has so far mostly happened in the deployment workflows. PR actions that call the same script do install the dependency already.

For e.g. sel4test PRs, the repo checkout is part of the hardware build action. We could probably simplify the PR workflow in sel4bench to do the same as sel4test (i.e. just leave out the Freeze Code step), because there aren't any other parts of the workflow that check out anything and where it would be critical that they see the exact same versions, but I think I prefer keeping the workflow file as close to the deployment workflow as possible (it would be nice to merge them, but doing that is fairly messy).

I've added the module to the setup part of repo-checkout, which should fix the problem.

from sel4bench.