make user does not work about sel4-camkes-l4v-dockerfiles HOT 5 CLOSED

Hello, thanks for the report!

Can you run:

docker images

so we can see the IMAGE IDs

from sel4-camkes-l4v-dockerfiles.

REPOSITORY                  TAG                 IMAGE ID            CREATED             SIZE
<none>                      <none>              7123a57c7bd5        21 hours ago        4.82GB
extras                      latest              02560e099951        21 hours ago        4.82GB
trustworthysystems/camkes   latest              a33752e29215        36 hours ago        4.63GB
alpine                      latest              a187dde48cd2        3 months ago        5.6MB

from sel4-camkes-l4v-dockerfiles.

Thanks.

OK, it looks like there is a bug, because the group users exists in the container already.

The groupadd command runs, and tries to make another users group - and because it has -f, it doesn't fail - but it also does not change the group ID to match the groupadd command.

I was able to fix this by putting in this line:

 # Crammed a lot in here to make building the image faster
 RUN groupadd -fg ${GID} ${GROUP} \
+    && groupmod -g ${GID} ${GROUP} \
     && useradd -u ${UID} -g ${GID} ${UNAME} \

in the dockerfiles/user.dockerfile, just after this line here: https://github.com/SEL4PROJ/seL4-CAmkES-L4v-dockerfiles/blob/df998a4beed9d5109d564d8b0552ab118af25365/dockerfiles/user.dockerfile#L11

The fix just changes the GID of the group - if it's already correct, it won't change anything. If it has hit an existing group, it will change the group ID. Hopefully shouldn't cause any issues.

Are you able to test this out, and let me know if it helps? I have pushed the fixed commit to our internal system, but it will take a little while to make it out of of CI, and on to GitHub.

from sel4-camkes-l4v-dockerfiles.

I can confirm it works.

from sel4-camkes-l4v-dockerfiles.

Great! The fix should get pushed out soon.

from sel4-camkes-l4v-dockerfiles.