Comments (3)
That is probably easy to add, and would be useful, yes.
Does this add any new security considerations? So far, a PR must have been raised for the target to be included. Pretty much anyone can do that (apart from blocked users). So the new scope is someone pointing to some branch in a different org they control, but if they are a first-time contributor the tests have to be manually approved first anyway, so I think this is fine.
from ci-actions.
Looking at https://github.com/seL4/ci-actions/pull/217/files, this could also support hashes. This feature might come for free if this is implemented with the standard git tools. Otherwise is should implement the same behavior, that matching a branch name take preference over matching a commit id.
from ci-actions.
It'll not be entirely free, because constructing the ref for a PR is a bit special, but it could be done relatively easily. The relevant lines in scripts/fetch-extra-prs.sh are these:
ci-actions/scripts/fetch-extra-prs.sh
Lines 29 to 34 in 2416319
We'd need to do something similar as in fetch-branch.sh to distinguish pulling a sha from pulling a ref:
ci-actions/scripts/fetch-branch.sh
Lines 33 to 45 in 2416319
from ci-actions.
Related Issues (20)
- adjust sel4bench parameters for hifive
- use l4v sorry-count.sh
- update actions to node16
- update use of `set-output` HOT 1
- make sel4bench run available on seL4 PRs HOT 1
- compile action should test MCS HOT 2
- fix set-ouput breakage HOT 2
- find hg versions that work for the Isabelle mirror HOT 2
- Using fork of ci-action fails HOT 2
- Build and simulate sel4test for Microchip PolarFire Icicle Kit HOT 1
- Build seL4 and seL4test for all supported platforms HOT 5
- thylint action should not fail on deleted files
- preprocess bump for MCS
- record successful test revisions for mcs.xml
- ARM_MCS_verified.cmake not used by CI when running seL4/ci-actions/standalone-kernel HOT 2
- Drop march from platforms.yml if there is no use HOT 4
- upgrade actions to Node 20 HOT 4
- python style check fails with internal error HOT 5
- Dockerhub still advertises obsolete trustworthysystems/sel4-riscv HOT 1
- vm_minimal_sim run failure is not reported HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ci-actions.