Giter Club home page Giter Club logo

Comments (3)

gempa-jabe avatar gempa-jabe commented on August 20, 2024

That sounds great @luca-s. Not that I have tested your locator but I am pretty confident that something that complements your homogeneous travel time tables and serves as an additional locator options is a great and valuable addition. And the fact that your are still active with development so that bugs and issues are going to be fixed makes this integration very tempting. I have no issues accepting a PR. I only have to check formatting of the source ;).

Btw, as more algorithms require standard code such as fitting methods or statistical methods it would be great to put them all into one place and homogenize them. I know that this is not gonna be fun but the 3rd-party directories are kind of hidden and other code won't be able to re-use it, especially in a plugin.

from common.

luca-s avatar luca-s commented on August 20, 2024

Good, then I will provide the PR where we can discuss changes in more details. I am pretty sure there are user level configuration parameters that you might want to modify, clarify and what not.

Should I follow the homogeneous approach where I put GenLoc code in an anonymous namespace to avoid polluting the SeisComP one?

from common.

luca-s avatar luca-s commented on August 20, 2024

We can move the discussion here #84

from common.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.