Giter Club home page Giter Club logo

Comments (5)

sehmaschine avatar sehmaschine commented on July 29, 2024

if you don´t use versions ... why not just change/override the settings?

but yes, using a timestamp is another possibility. to anybody working on a patch:
I´d prefer a callback for generating the version_name in order to customize the behaviour. please take a look at the commands as well.

from django-filebrowser.

lucaswelper avatar lucaswelper commented on July 29, 2024

I still plan on using versions, but don't see the problem being what I choose for version names. I will always run the risk of the user uploading a file that ends in whatever name I choose. Applying a timestamp would guarantee that the name of the user's file does not conflict.

from django-filebrowser.

hordurk avatar hordurk commented on July 29, 2024

I just encountered this issue. If there certain illegal filenames, the upload should at least fail with an error instead of uploading OK, but the file never showing up.

from django-filebrowser.

sehmaschine avatar sehmaschine commented on July 29, 2024

@hordurk we should not solve it with preventing uploads since one could use FTP to upload files as well – from my point of view, it' s better to use a unique version_name.

from django-filebrowser.

sehmaschine avatar sehmaschine commented on July 29, 2024

see 9455f9b

we do not filter the list anymore, if VERSIONS_BASEDIR is being used (which is recommended). so I guess this issue is solved.

please reopen if you think there's still an improvement to be made.

from django-filebrowser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.