Giter Club home page Giter Club logo

Comments (3)

Fenny avatar Fenny commented on May 18, 2024 1

There is no particular reason to use 1.13, but if it means it's not cross-compatible with other projects that run on 1.11 or higher for example. I think we should adjust the go.mod, I can make a PR for this.

from encoding.

abraithwaite avatar abraithwaite commented on May 18, 2024

This is a result of this change in Go1.14:

https://golang.org/doc/go1.14#encoding/json

Unfortunately, Go1.13 is now deprecated with the release of Go1.15. I could be wrong, but I believe we're taking the same approach around deprecation timelines, so (understanding I haven't read the code for this issue) I think it's unlikely to be fixed.

Is there something keeping you on Go1.13 in particular?

Edit: reading more closely, it seems like this ticket is more about Go1.13 being listed as supported by the Go mod file. Seems reasonable that we should probably bump that if this is our stance.

from encoding.

achille-roussel avatar achille-roussel commented on May 18, 2024

The reason the tests failed is because there was a behavior change in encoding/json in Go 1.14 that we ported to this project (see #34).

The path forward should be to update go.mod to require Go 1.14 (like @abraithwaite suggested), if you want to remain on Go 1.13 you should use segmentio/encoding v0.1.10 (although that may not be a great option since it means giving up on some bug fixes).

from encoding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.