Embedded structs don't have their config merged up about conf HOT 7 CLOSED

Would you be able to submit a patch?

Although there may be code that rely on the current behavior that would get broken by such a change.

Is your current workaround to copy the fields directly in the struct?

from conf.

My current workaround is just to live with a prefix. It's not a major issue right now and I don't plan on working on it anytime soon, but it's low hanging fruit for anyone who wants to take a shot.

from conf.

Cool.

I've been thinking about how to avoid those kinds of discrepancies. Currently we build an intermediary representation of the configuration in memory, which we then convert to the configuration struct type.

Instead of doing this we could serialize the configuration to JSON, then use the standard JSON decoder to load values into the configuration struct. This way there can be no behavior differences (this is the approach taken by packages like https://github.com/ghodss/yaml for example).

Food for thoughts!

from conf.

In order to avoid breaking compatibility, what do you guys think about using _ as the special tag to indicate that the embedded struct shouldn't be prefixed?

I'm thinking about taking a stab at this too (my particular use case is creating and embedding general Suppressor configuration to be shared between the Kafka and NSQ apps). Happy to brainstorm further because this would be a really cool feature.

from conf.

That sounds like a good idea to me 👍

from conf.

Doing it backward-compatible seems like a good first step, if you want to make it the default then we can tag a v1 release of the package, and introduce the change afterward.

from conf.

This was fixed in #23.

from conf.