Giter Club home page Giter Club logo

Comments (1)

michaeltaranto avatar michaeltaranto commented on May 28, 2024

I've gone back and forth on this one.

The reason we dont expose them, is any change to these values externally will have an impact on the trimming, which feels undesirable.

We do have the precomputeValues utility that allows you to resolve the values for your own use, and then pass these into createTextStyle, so you effectively middleman the process without updating the values. Granted its still exposed to passing incorrect values in, but given this is at build-time maybe its less likely to get wrong as opposed to changing a CSS var at run-time?

Here is an example:

// text.css.ts
import { precomputeValues } from '@capsizecss/core';
import arialMetrics from '@capsizecss/metrics/arial';
import { createTextStyle } from '@capsizecss/vanilla-extract';
import { style } from '@vanilla-extract/css';

const capsizeValues = precomputeValues({
  fontSize: 16,
  leading: 24,
  fontMetrics: arialMetrics,
});

export const text = createTextStyle(capsizeValues);

export const icon = style({
    height: capsizeValues.lineHeight,
    width: capsizeValues.lineHeight,
    marginTop: capsizeValues.capHeightTrim,
    marginBottom: capsizeValues.baselineTrim
});

from capsize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.