Code questions about azworkspacemanager HOT 2 CLOSED

Sure mate, happy to help!

If you need input apart from PRs you know where to find me 😄.

from azworkspacemanager.

Thank you @Manbearpiet for your detailed review and code improvement suggestions.
Much appreciated that you have taken the time to go through the code.

Get-AccessToken and Get-LogAnalyticsWorkspace

In some cases I have created my own functions like Get-AccessToken and Get-LogAnalyticsWorkspace. Main reason to this is to limit the dependency on other modules, especially when using in automation scenario's I am a fan of a minimal footprint like in GitHub, DevOps or using in Function Apps.

The Invoke-AzRestMethod is not always very stable and consistent in the output of the queried resources, so trying to avoid that a little bit also.

FunctionNames

I was hoping Microsoft would pick this up in their own repository as an extension to the already existing Microsoft modules. 😊

Others

I will pick-up the other suggestions, and appreciate if I could add you as a reviewer on the PR.
Pester Testing is something I do need to add, but didn't had the inspiration yet to think of what I would like to test.

from azworkspacemanager.