Giter Club home page Giter Club logo

Comments (11)

mheon avatar mheon commented on May 28, 2024

This looks similar to a bug that was fixed in libseccomp v2.2.1. Are you building for Debian stable? If so, I believe you're still on a version of libseccomp early enough for that bug to appear... but then again, there are compile-time checks to make sure that specific combination cannot build.

I'll look into this more this afternoon.

from libseccomp-golang.

rogers0 avatar rogers0 commented on May 28, 2024

@mheon yes, for debian stretch, the next stable.
now stretch has been frozen, which means we can only patch current version, but cannot update to your latest release.
if you can provide a backport patch to fix the unit test issue on x86, it'd be appreciated!
thank you!

from libseccomp-golang.

mheon avatar mheon commented on May 28, 2024

Stretch should be too new to see that specific bug, as it ships v2.3.1, so this is probably a bug in the bindings.

The Git snapshot you're using is a little old and missing most of the recent work that has gone in, so hopefully it's just a matter of applying one or two of those newer patches. There was a significant bugfix patch last week that might be related (06e7a29 in master), and hopefully applying that will resolve it. I'll spin up a test VM and check.

from libseccomp-golang.

rogers0 avatar rogers0 commented on May 28, 2024

@mheon thanks for your prompting response!

I tried cherry-pick 06e7a29, and build in git-pbuilder, the result is the same as before.
I guess maybe we need to cherry-pick more commits ...

from libseccomp-golang.

mheon avatar mheon commented on May 28, 2024

Could be unrelated to that bug, then. It's interesting that it's 32-bit only. I begin to suspect it's the syscall being used in the test - maybe a behavior difference between 32 and 64 bit versions that glibc abstracts away but Go's standard library doesn't.

from libseccomp-golang.

mheon avatar mheon commented on May 28, 2024

I have verified that this issue still exists in up-to-date master. I'll look into the cause now and see about getting it patched.

from libseccomp-golang.

mheon avatar mheon commented on May 28, 2024

I've replicated the result in C (calling directly into libseccomp without using the libseccomp-golang bindings). This appears to be a bug in libseccomp itself. I'll file it upstream there.

from libseccomp-golang.

rogers0 avatar rogers0 commented on May 28, 2024

@mheon thanks for your info!

from libseccomp-golang.

rogers0 avatar rogers0 commented on May 28, 2024

@mheon reading the #84 issue of seccomp/libseccomp, though I'm quite sure, I feel this may be fixable without touching libseccomp. So is there a patch for golang bindings? Thank you!

from libseccomp-golang.

mheon avatar mheon commented on May 28, 2024

@rogers0 Sorry for the delay on this one. You're correct, it looks to be an error in the test suite for the bindings. I have a test patch available at https://github.com/mheon/libseccomp-golang branch test-failure-32bit, commit b03f1ef - can you verify this resolves the issue? If it does, I'll get it merged into master.

from libseccomp-golang.

rogers0 avatar rogers0 commented on May 28, 2024

@mheon Thanks for your patch!
I confirm it fixes the build on i386. I already make the debian release, and now is waiting for sponsor to upload to debian archive.

from libseccomp-golang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.