PeNet.FileParser.StreamFile - ReadUnicodeString function issue - infinate loop about penet HOT 7 CLOSED

Hi @Bobbymac001, thanks for reporting the bug. Do you have any file I can test the behavior with? Probably a SHA256 or MD5 is enough, as it may already be in my malware collection.

from penet.

Hello @secana, not a problem. Thank you for building this library and maintaining it. 🥇

I was running through a VirusShare batch from 00437 when started getting several that triggered it. It took me a while to figure out what was going on - it was shifting into an infinite loop statement when I checked properties for null values in the resources object of the PeFile.

`if (pef.Resources != null && pef.Resources.VsVersionInfo != null && pef.Resources.VsVersionInfo.StringFileInfo != null && pef.Resources.VsVersionInfo.StringFileInfo.StringTable != null) {

It was the VsVersionInfo check that first fell into the infinite loop.

There were a bunch in the VirusShare batch 00437 that triggered the same behaviour, but one that I identified and reproduced it myself to figure out what was going on was Trojan.Win32.Agent.icgh-184d64373ca83cfcf50c535fa70d68bfdf32392dbe4e42171fe8b818309a0ee0.

I can remove the escape clause and find more if that doesn't work.

from penet.

@Bobbymac001 can you check if it is fixed in 2.9.9-pre1?

from penet.

@secana, I'll apply both sets of changes to the codebase over the weekend, and test/validate soon as I have a window to dig out the samples...

from penet.

@secana, I applied the code changes and tested and didn't have any issues with the specific samples I knew about. I'm about to rerun the data extraction on the whole repository (over a few days) and will add another 40K samples through the week - I'll let you know if anything else pops on either, but looks good/solved.

from penet.

@Bobbymac001 thanks a lot. If everything works as expected, I'll release the non-preview version.

from penet.

Hey There, sorry for the late reply, had some other work that took priority. I ran a small subset of the batch and didn't have any issues. I need to do an 80K run later this week, but as far as I can tell it's working as expected now.

from penet.