Updating v0.3.2 -> 0.4.1 breaks SQL formatting about prettier-plugin-embed HOT 7 CLOSED

Nice! That seems to be working again 🙌

from prettier-plugin-embed.

I'm not sure but maybe this is related?

from prettier-plugin-embed.

Can you provide a repro setup?

VS Code Prettier extension warnings/errors are logged by its own logging service which is not exposed to the plugins so I cannot log errors or warnings in the output panel. If you open the devtools of VS Code, the errors may appear in that window (if there're errors).

The breaking changes are the behaviors of the ruby plugin and I reduced the amount of default identifiers to only the common ones. And I've also added this line of note in the README file. Some new languages are added in v0.4.x compared to v0.3.2, but I don't see them as breaking changes. But maybe I broke something in the process.

This project is still in early stage, lacking tests, and I'm still trying to learn and find the appropriate process to maintain this repo. Any kind of contribution to help me organize this repo in a more maintainable way is welcome.

from prettier-plugin-embed.

The prettier.config.mjs contains:

// @ts-check
// ignore unused exports default

// The Prettier plugin config types are temporarily avoided due to this issue:
// https://github.com/Sec-ant/prettier-plugin-embed/issues/52

// @type {import("prettier-plugin-embed").PrettierPluginEmbedOptions}
/** Prettier config for the plugin `prettier-plugin-embed`. */
const prettierConfigPluginEmbed = {
  embeddedSqlIdentifiers: ["sql", "redactedSql"],
};

// @type {import("prettier-plugin-sql").SqlBaseOptions}
/** Prettier config for the plugin `prettier-plugin-sql`. */
const prettierConfigPluginSql = {
  language: "postgresql",
};

/**
 * Prettier config.
 * @type {import("prettier").Config}
 */
const prettierConfig = {
  plugins: ["prettier-plugin-embed", "prettier-plugin-sql"],
  ...prettierConfigPluginEmbed,
  ...prettierConfigPluginSql,
};

export default prettierConfig;

from prettier-plugin-embed.

This is indeed a regression, sorry for the trouble. Can you test v0.4.3 to confirm whether it is fixed for your use case?

from prettier-plugin-embed.

Hmm, something else that seems to have changed, is now the default behavior is not to format the keyword capitalization. You have to explicitly add keywordCase: "upper" in the SQL plugin config.

from prettier-plugin-embed.

Actually, maybe that stopped working before the v0.4 update, because now I have updated the Prettier config to enforce SQL keyword case, I'm finding Prettier formatting errors for some of the SQL committed in the last week. Maybe that default changed due to an earlier update of either prettier-plugin-embed or prettier-plugin-sql.

from prettier-plugin-embed.