Giter Club home page Giter Club logo

Comments (6)

phiggins avatar phiggins commented on June 27, 2024

You sorta threw out two suggestions there:

  1. Use JS / CSS to make the description field dynamically resizable.
  2. Truncate the text in the view and add a link to the talk's page indicating that the text was cut off.

I think 2 is more in keeping with the non-dynamic-ness of the site, but either would be ok with me.

from seattlerb.org.

tlynam avatar tlynam commented on June 27, 2024

This truncates to 200 characters, adds ... and a read more link to the talk. Is it okay to use raw? Do we know a good character limit?

<p class="description"><%= raw talk.description.truncate(200, separator: ' ', omission: "...%s") % link_to("read more", talk) %></p>

from seattlerb.org.

phiggins avatar phiggins commented on June 27, 2024

Is it okay to use raw?

Since this comes from user input, it's not safe to use raw.

from seattlerb.org.

zenspider avatar zenspider commented on June 27, 2024

@tlynam can you whip up a PR?

from seattlerb.org.

zenspider avatar zenspider commented on June 27, 2024

Next time if your PR says "Fixes #64" in the title it'll close this at the same time.

from seattlerb.org.

tlynam avatar tlynam commented on June 27, 2024

I see @zenspider thanks!

from seattlerb.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.