Comments (4)
Great! I think saving filter selection in local storage is a good idea, but as a user on the page refresh, it makes more sense (at least over here) to reset filters. Just my two cents!!
from leetcode-patterns.
Hey @Yashwin12 ✌🏽 Thanks a bunch for pointing this bug out - I just tried reproducing it using the STR you listed but it looks like filtering is working as intended:
filtering-combined.mp4
Are you able to reproduce it in Incognito mode, or just the regular website? We can try to narrow down what's busted from there
from leetcode-patterns.
Hi @seanprashad, thank you for replying back. Actually, I found why it was behaving like this; I accidentally hit the "previous" button in the browser. Please consider below STR and gif to reproduce the filter issue.
- Select company filter. ( Over here "Capital One" is selected )
- Navigate to the "previous" page in the browser.
- Navigate back to the Leetcode Patterns page. You can still see the filter value is present, but the values are not shown according to its filter. (I think it disregards the filter value and shows all the results).
from leetcode-patterns.
Amazing stuff! I am also able to confirm the bug based on your updated STR listed.
The current behaviour doesn't save your settings (ie. Which difficulty, companies, and patterns you have filtered by, if any).
Over in #87, it was requested that these settings be saved like how the checkboxes are via Local Storage. As of right now, I think this is a UI bug which will hopefully be solved when #87 lands!
from leetcode-patterns.
Related Issues (20)
- Problems pattern frequency doesn't show colors for new companies HOT 6
- Ensure GitHub Pages redeploys after scheduled run-cron job HOT 3
- [Ongoing] Add missing company icons HOT 1
- Website is down HOT 5
- Switching order of reverse linkedlist and palindrome linkedlist? HOT 2
- Patterns HOT 1
- Add lists feature HOT 1
- how do i get started using this repository on my local machine? HOT 1
- Project set up instructions HOT 2
- Add "283. Move Zeroes" to "Two pointers" HOT 3
- Design Gurus & original author acknowledgements HOT 1
- "Backtracking" missing problems HOT 1
- "Sliding Window" missing problems HOT 2
- "Fast & Slow Pointers" missing problems HOT 1
- "Two Pointers" missing problems
- There are two same type of dropDown items in dropDown HOT 1
- "Intervals" missing problems
- Amazon/Facebook don't ask DP problems
- Tips page UI improvement HOT 1
- The need for an authentication system. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leetcode-patterns.