Keep range name when constructing networks from range data objects about coronet HOT 6 CLOSED

That's a good idea to add the attribute. I have just one question: What should be added to the attribute in the case of a ProjectData object or, rather, should the attribute added in this case at all?

Ah, another question: What about a downgrade to version v2.3?

from coronet.

What should be added to the attribute in the case of a ProjectData object or, rather, should the attribute added in this case at all?

Good question. Either we are able to somehow determine the global range - which could be very difficult to determine. Or we just add a String saying that this covers is the whole ProjectData, e.g. global. Or we do not add the attribute in that case, which would be the easiest solution in my opinion.

In the end, it depends also on the implementation: How difficult is it to determine whether a data object is a RangeData object or a ProjectData object?

I would suggest to add the range attribute only when a RangeData object is used for network construction.

from coronet.

Good question. Either we are able to somehow determine the global range - which could be very difficult to determine. Or we just add a String saying that this covers is the whole ProjectData, e.g. global. Or we do not add the attribute in that case, which would be the easiest solution in my opinion.

We would need to add a method ProjectData$get.range() returning the pre-defined string for project-level data objects and, then, use attr(network, "range") = private$proj.data$get.range() to add the attribute.

In the end, it depends also on the implementation: How difficult is it to determine whether a data object is a RangeData object or a ProjectData object?

if ("RangeData" %in% class(private$proj.data)) {
  ## do something
}

I would suggest to add the range attribute only when a RangeData object is used for network construction.

Okay, I will implement it that way.

from coronet.

Ah, another question: What about a downgrade to version v2.3?

As this is not a bug and does not cause any errors, I would not add this to version v2.3.

Meanwhile, there are lots of enhancements which will not be available for version v2.3.
As there will be lots of new features in version 3, all users should update to version 3, then, if one wants to use one of the new features.

from coronet.

@hechtlC, @flx5: The patch does not affect the network-related test as we use igraph::identical_graphs to check the equality of two networks. This function does not check the attributes.

from coronet.

By merging #64 into dev, this can be regarded as closed.

from coronet.