Comments (6)
That's a good idea to add the attribute. I have just one question: What should be added to the attribute in the case of a ProjectData
object or, rather, should the attribute added in this case at all?
Ah, another question: What about a downgrade to version v2.3?
from coronet.
What should be added to the attribute in the case of a ProjectData object or, rather, should the attribute added in this case at all?
Good question. Either we are able to somehow determine the global range - which could be very difficult to determine. Or we just add a String saying that this covers is the whole ProjectData
, e.g. global. Or we do not add the attribute in that case, which would be the easiest solution in my opinion.
In the end, it depends also on the implementation: How difficult is it to determine whether a data object is a RangeData
object or a ProjectData
object?
I would suggest to add the range attribute only when a RangeData
object is used for network construction.
from coronet.
Good question. Either we are able to somehow determine the global range - which could be very difficult to determine. Or we just add a String saying that this covers is the whole ProjectData, e.g. global. Or we do not add the attribute in that case, which would be the easiest solution in my opinion.
We would need to add a method ProjectData$get.range()
returning the pre-defined string for project-level data objects and, then, use attr(network, "range") = private$proj.data$get.range()
to add the attribute.
In the end, it depends also on the implementation: How difficult is it to determine whether a data object is a RangeData object or a ProjectData object?
if ("RangeData" %in% class(private$proj.data)) {
## do something
}
I would suggest to add the range attribute only when a RangeData object is used for network construction.
Okay, I will implement it that way.
from coronet.
Ah, another question: What about a downgrade to version v2.3?
As this is not a bug and does not cause any errors, I would not add this to version v2.3.
Meanwhile, there are lots of enhancements which will not be available for version v2.3.
As there will be lots of new features in version 3, all users should update to version 3, then, if one wants to use one of the new features.
from coronet.
@hechtlC, @flx5: The patch does not affect the network-related test as we use igraph::identical_graphs
to check the equality of two networks. This function does not check the attributes.
from coronet.
By merging #64 into dev
, this can be regarded as closed.
from coronet.
Related Issues (20)
- Add input validation for setter functions
- Handle empty user correctly
- Filter "deleted user" correctly
- Missing data in `get.first.activity.data` leads to an error
- Tidy-up and optimize source-code inconsistencies
- Enhance `metrics.vertex.degrees` to also be able to compute in-degrees and out-degrees
- Simplified artifact networks have double of their intended edge weights HOT 1
- Test suite fails when using "igraph" versions >= 1.4.0 HOT 1
- Create edges for `artifact relation` `issue` HOT 2
- Tests for functionality in util-networks-misc.R
- Generate coverage reports for our test suite and integrate it into our CI HOT 2
- Error message logging in `metrics.smallwordness` is broken
- Fix edge-attribute handling when simpliyfing networks HOT 8
- Make warnings more uniform HOT 1
- Allow to specify `split.basis` by stating multiple data sources and start splitting according to the earliest data source HOT 4
- Wrong bins attribute after sliding-window-based network splitting & inconsistent behavior of `construct.ranges` HOT 6
- Update deprecated function calls from other packages HOT 10
- `construct.ranges` for cumulative ranges
- Handle mail data of projects that use multiple mailing lists correctly
- Splitting behavior: What to do with elements that occurred before the predefined splitting bins? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coronet.