Streams support about mock_redis HOT 8 CLOSED

And I see that the README has 'The current implementation is tested against Redis 4' so there is no reason at all why Streams should be available yet. I'd still be interested to know, though. :-)

from mock_redis.

We have no explicit plans to support streams. Would happily merge a pull request adding support, however. 😄

from mock_redis.

Thanks. I'm not promising anything but I have started looking at implementing this here: https://github.com/jrmhaig/mock_redis

One slight problem I have is that the ids assigned to the stream items are based on the current time in milliseconds and this means that one of my tests occasionally fails because the id created by the real Redis server differs from the one created by MockRedis by one millisecond. Is there a way to make the comparison done by RSpec a little less strict?

Also, before I go too far down this route do you have any comments regarding naming conventions or anything else?

from mock_redis.

Rather than test that the ID matches the timestamp, would it make sense to instead test that the ID is always monotonically increasing?

Otherwise you'll necessarily have to construct the test to give yourself some wiggle room for checking the ID.

from mock_redis.

The problem isn't with the test itself but rather with the comparison that is done before with the real Redis server.

from mock_redis.

In that case I unfortunately don't have a good workaround to suggest.

from mock_redis.

Thanks for your work on this in #142 and #156, @jrmhaig.

from mock_redis.

Going to close this issue since a decent chunk of work was implemented. Thank you @jrmhaig!

If anyone wants to see additional support, pull requests are very much welcome!

from mock_redis.