Giter Club home page Giter Club logo

Comments (5)

sdroege avatar sdroege commented on August 23, 2024 1 
1. Is my workaround just a hack? Is it best practice to broadcast the close message so other clients know one client has closed?

I think that's the correct way of doing it, yes. Broadcasting the normal close message will close the connection for everybody, which is usually not what you want.

2\. Should the example be updated?

I think that was be useful, thanks :)

from async-tungstenite.

sdroege avatar sdroege commented on August 23, 2024 1

I guess this can be closed now? :) If not tell me and I'll reopen.

from async-tungstenite.

mlodato517 avatar mlodato517 commented on August 23, 2024

Hmm, this is actually interesting though. If I run your server-client example, I don't see this behavior (where closing one client closes the rest of the clients). I'm not sure if this is specific to when the client is a JS websocket client or something? I'm interested in your intuition on this:

  1. I started the server:
cargo run --features="async-std-runtime" --example server 127.0.0.1:12345
  1. I started a rust client:
cargo run --features="async-std-runtime" --example client ws://127.0.0.1:12345/
  1. I added an index.html file to examples:
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
  </head>
  <body>
    <script>
      document.addEventListener('DOMContentLoaded', function() {
        const ws = new WebSocket('ws://127.0.0.1:12345');

        ws.addEventListener('open', function() {
          ws.addEventListener('message', function({ data }) {
            console.log(data)
          })
          ws.addEventListener('close', function() {
            console.log('closed')
          })
        })
      })
    </script>
  </body>
</html>
  1. I opened index.html in two windows - one in FF, one in chrome just be safe.
  2. I typed into the rust client and saw a blob logged in the console of both windows to ensure the broadcast was working.
  3. Now, if I close either browser tab, it closed the other browser tab and the rust command-line client.

But if I connect with two rust clients and close one, the other client doesn't close. Also if I connect with one rust client and one JS client and then close the rust client, the JS client isn't closed. Do you think this is a JS bug or something instead of an issue with broadcasting the close message?

Tangentially I noticed that if you try running the command listed at the top of the example, you get an error:

error: target `client` in package `async-tungstenite` requires the features: `async-std-runtime`
Consider enabling them by passing, e.g., `--features="async-std-runtime"`

Do you want me to update the commands in the example or should we leave it as to keep the commands shorter because the error is so well written?

from async-tungstenite.

sdroege avatar sdroege commented on August 23, 2024

Hmm, this is actually interesting though. If I run your server-client example, I don't see this behavior (where closing one client closes the rest of the clients). I'm not sure if this is specific to when the client is a JS websocket client or something? I'm interested in your intuition on this:

Maybe no Close message is sent in that case but the underlying TCP connection is just closed? If you just quit the Rust application it will simply stop and not have the opportunity to cleanly close the websocket connection (i.e. sending the Close message). And because of that, this message also wouldn't be broadcasted. Sending the Close message is optional and you'd have to do that explicitly in the Rust code.

Are you saying your code is not behaving the same as the examples, can you share your code in that case? :)

Do you want me to update the commands in the example or should we leave it as to keep the commands shorter because the error is so well written?

Updating those would be a good idea, thanks :)

from async-tungstenite.

mlodato517 avatar mlodato517 commented on August 23, 2024

If you just quit the Rust application it will simply stop and not have the opportunity to cleanly close the websocket connection

Ah! That could very well be it. Great, I'll go ahead with those updates then.

from async-tungstenite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.