Comments (6)
I have a fix for this I'm happy to submit a PR for. Wanted to get feedback on the first one though since this fix relies on that PR.
Also, fixing this issue lead me to discover bug #51.
from triflejs.
Thanks @tejacques, I agree its better this way. Just have to check unit tests after doing the merge. Will get to this after more delicate work on page.onCallback.
from triflejs.
I've integrated this functionality into 'Navigated' event as you suggested, thanks for picking this up.
Just need to add a couple of unit tests for page.onError.
from triflejs.
Hi @tejacques,
Did you manage to get JS error handlers to fire at all using browser.Document.Window.Error += delegate(object obj, HtmlElementErrorEventArgs e)
?, I had to give up on this approach which worked last time I look at it about a year ago. Instead I'm using injected javascript to capture window.onerror
, which works more predictably.
Fix is ready, feel free to take a look and provide any comments. Ta.
from triflejs.
Pretty much all I had to do to get it to work in some simple tests was moving browser.Document.Window.Error += delegate(object obj, HtmlElementErrorEventArgs e)
to the Navigated
event.
from triflejs.
Hmm that didnt work for me, I wonder if its different OS or IE version (I'm Win7 x86 running IE11). Or perhaps I've stuffed up my mshtml.dll reference by fiddling with it.
from triflejs.
Related Issues (20)
- window.setTimeout never triggers after 3s HOT 1
- Avoid Window popup HOT 2
- Window SetTimeout / SetInterval don't work when building from source HOT 2
- WebPage.onInitialized is not called when set HOT 7
- TriffleJS --render fails on http://livedoor.com/ HOT 11
- window.callPhantom doesn't trigger page.onCallback after page.load HOT 8
- page.onCallback() does not handle dates HOT 1
- Can trifleJS use Chakra instead of V8? HOT 3
- clipRect can not work well HOT 2
- Question: Any plans to make this work outside of windows? HOT 1
- System args not populating
- Render pages supplied as text
- TrifleJs in Windows Server
- Crash: Vector smash protection is enabled. HOT 1
- System.IO.FileNotFoundException HOT 1
- webpage method
- uriString can not be null exception when emulating
- trifleJS shut down & builds error :Please install Windows SDK 2010. HOT 1
- About command mode high concurrency HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from triflejs.