window.callPhantom and unhandled error logging are not available until onload event fires. about triflejs HOT 6 CLOSED

I have a fix for this I'm happy to submit a PR for. Wanted to get feedback on the first one though since this fix relies on that PR.

Also, fixing this issue lead me to discover bug #51.

from triflejs.

Thanks @tejacques, I agree its better this way. Just have to check unit tests after doing the merge. Will get to this after more delicate work on page.onCallback.

from triflejs.

I've integrated this functionality into 'Navigated' event as you suggested, thanks for picking this up.

Just need to add a couple of unit tests for page.onError.

from triflejs.

Hi @tejacques,

Did you manage to get JS error handlers to fire at all using browser.Document.Window.Error += delegate(object obj, HtmlElementErrorEventArgs e)?, I had to give up on this approach which worked last time I look at it about a year ago. Instead I'm using injected javascript to capture window.onerror, which works more predictably.

Fix is ready, feel free to take a look and provide any comments. Ta.

from triflejs.

Pretty much all I had to do to get it to work in some simple tests was moving browser.Document.Window.Error += delegate(object obj, HtmlElementErrorEventArgs e) to the Navigated event.

from triflejs.

Hmm that didnt work for me, I wonder if its different OS or IE version (I'm Win7 x86 running IE11). Or perhaps I've stuffed up my mshtml.dll reference by fiddling with it.

from triflejs.