Resampling block about neuralampmodelercore HOT 8 CLOSED

I've got some really good results with the Lancsoz resampler, which has much less aliasing that the interpolation modes and is fast and only adds a tiny bit of latency: sdatkinson/NeuralAmpModelerPlugin#341

from neuralampmodelercore.

Once I fixed that bug. Lol. Glad to see it helps!

from neuralampmodelercore.

Coming back to this, I don't think it makes sense to implement the resampler here: same as AudioDSPTools, it's not "NAM-specific" and others may have their own favorites already.

Still, I definitely appreciate the input on this Issue and will be referencing it as I work on getting resampling in my plugin; thanks!

from neuralampmodelercore.

Yes! You can look at the resampler from JUCE for inspiration. I've been using it with NAM since last summer and it works perfectly for this exact purpose. So might as well port it to NAM. I use a LagrangeInterpolator from here -> https://docs.juce.com/master/classGenericInterpolator.html

from neuralampmodelercore.

Oh, by the way, two more requests for that:

1. getLatency() method that tells us how many frames is the resampler's latency, so we can report it to the DAW to adjust PDC.
2. prepare() method to call outside audio thread that resizes those internal buffers every time sample rate or block size changes.

(obviously method names are arbitrary)

from neuralampmodelercore.

A few years ago this was considered the highest quality open source resampling library from the master behind Voxengo plugins: https://github.com/avaneev/r8brain-free-src. I assume it still is, check it out!

from neuralampmodelercore.

I am not sure that the cubic resampler WIP in the NeuralAmpModelerCore repo will be of high enough quality. Cubic resampling will introduce a lot of aliasing. But r8brain-free-src is not designed for real time usage afaik, and will be too heavy. I propose to use either WDL_Resampler or perhaps this which @baconpaul kindly MIT'd for me.

from neuralampmodelercore.

Implementing WDL_Resampler in the plug-in code would be simple

from neuralampmodelercore.