Giter Club home page Giter Club logo

Comments (16)

sdasda7777 avatar sdasda7777 commented on August 15, 2024 1

Hi, you're right, I would hope that would work as well. I seem to be able to replicate it somewhat, I'll look into it asap.

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024 1

Hmm, I see. I'll try fixing the initial check issue at the very least, maybe something pops up.

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

I thought regular expression would be 'youtube', 00:00-20:00,22:00-23:59 in 'hard locked', leave 'timer' and 'soft locked' empty.

@FernandoBMartin Can you confirm that if you do this, it triggers as long as you wait on the page for about 15 seconds?

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

I thought regular expression would be 'youtube', 00:00-20:00,22:00-23:59 in 'hard locked', leave 'timer' and 'soft locked' empty.

@FernandoBMartin Can you confirm that if you do this, it triggers as long as you wait on the page for about 15 seconds?

When I only use 00:00-20:00, it triggers after 15s as you said. When I use the 22:00-23:59 as well, it doesn't trigger at all.

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

I see, that's strange. Obviously you shouldn't have to wait 15 seconds for it to trigger, meaning the initial check seems to be broken.

Adding the 22:00-23:59 doesn't change this behaviour for me, though. Perhaps it's a separate bug? Would your current time happen to be in the 22:00-23:59 range? 🤔

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

I see, that's strange. Obviously you shouldn't have to wait 15 seconds for it to trigger, meaning the initial check seems to be broken.

Adding the 22:00-23:59 doesn't change this behaviour for me, though. Perhaps it's a separate bug? Would your current time happen to be in the 22:00-23:59 range? 🤔

No, it's actually 12:10 here

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

Oh, I think I figured it out. To have it trigger immediately, you have to also set the "Soft locked hours". I admit this is not very intuitive, but I'm not sure if this behaviour should be changed, in case it's useful for someone 😅

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

Oh, I think I figured it out. To have it trigger immediately, you have to also set the "Soft locked hours". I admit this is not very intuitive, but I'm not sure if this behaviour should be changed, in case it's useful for someone 😅

It does lock now, also when I have the 22:00-23:59 time range in. I'll get back to you when I know if it just works fine in general now. Thank you very much :)

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

Oh, I think I figured it out. To have it trigger immediately, you have to also set the "Soft locked hours". I admit this is not very intuitive, but I'm not sure if this behaviour should be changed, in case it's useful for someone 😅

Unfortunately it just unlocked before it should, I think there might still be a couple of things wrong with the code.
I definitely wish you all the best for this project and I'll check in on it some time, but as of now it's still too fragile to be practical. All the best and thanks for your effort!

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

Could you be more specific about the details of it misbehaving? I really can't fix it when I'm not sure what is broken 😄

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

Could you be more specific about the details of it misbehaving? I really can't fix it when I'm not sure what is broken 😄

Well, simple: I did what we last wrote about, it locked & showed the right countdown to when it should unlock.
I looked at it 10min before it should unlock and it was already unlocked. Same thing for twitter, with which I used the same setup.

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

Hmm, so after you clicked the "Go back" button, you were able to visit the site without it kicking you out? Or was the page already open when you visited the tab?

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

I had nothing open, didn't klick go back. Just typed the youtube URL, it opened, no lock.

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

I see. I'm really sorry, but unless I can personally replicate it, I can't really fix it. I'm currently not aware how this could happen when the extension is enabled. However, if you figure out anything that would at least hint as to under which conditions it works incorrectly, I would be happy to look into it.

from scheduleblock.

FernandoBMartin avatar FernandoBMartin commented on August 15, 2024

Not a problem mate, It was free so I'm not complaining at all.
I'll see if it locks again later, maybe check it some other time again, ok? :)

from scheduleblock.

sdasda7777 avatar sdasda7777 commented on August 15, 2024

Of course, thanks!

from scheduleblock.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.