building fails at warning about parentheses: about usrsctp HOT 7 CLOSED

Looks like it's failing on their own CI via GitHub actions as well (we noticed it via a CI we have that involves usrsctp). @tuexen any chance this can be fixed as @hboetes suggested? Or would you rather one of us prepare a PR with the fix?

from usrsctp.

For anybody else running into this issue, I think this should fix it. I bet the author will have an even better solution.

diff --git a/usrsctplib/netinet/sctp_output.c b/usrsctplib/netinet/sctp_output.c
index 7f79600..4d25c0e 100755
--- a/usrsctplib/netinet/sctp_output.c
+++ b/usrsctplib/netinet/sctp_output.c
@@ -9015,7 +9015,8 @@ again_one_more_time:
 					 * flight size since this little guy
 					 * is a control only packet.
 					 */
-					use_zero_crc = asoc->zero_checksum = 2;
+					asoc->zero_checksum = 2;
+					use_zero_crc = 2;
 					if (asconf) {
 						sctp_timer_start(SCTP_TIMER_TYPE_ASCONF, inp, stcb, net);
 						use_zero_crc = false;

from usrsctp.

Closed with f9f9502

from usrsctp.

use_zero_crc = asoc->zero_checksum = 2;
-> use_zero_crc = asoc->zero_checksum == 2;

from usrsctp.

Temp. workaround as described above by @hboetes :
sed -i -e 's|use_zero_crc = asoc->zero_checksum = 2;|asoc->zero_checksum = 2;\n\t\t\t\t\tuse_zero_crc = 2;|g' usrsctplib/netinet/sctp_output.c

from usrsctp.

@LeaTaka well, that really depends on what the original meaning of the commit was: was it a double assignment, as @hboetes assumed, or was it a "set this variable to 1 only if this other value is equal to 2" as @kschoi93 interpreted it instead? Without more context from the usrsctp developers, I'm not sure what patch makes more sense (since I'm not that familiar with the code internals).

from usrsctp.

that's right. i agree with you
It is not known which answer is correct unless the developer of usrsctp directly looks at this problem.

but I think it is a problem with the code writing rules of the C language.

I confirmed the commit to fix the problem code. @lminiero
f9f9502

from usrsctp.