Comments (6)
example commits (no PR because based on old release):
brenzi@480823e
brenzi@d01bc07
from substrate-api-client.
@brenzi I will have a look at it.
Just to clarify: The two commits from your comment would basically implement this? Or am I missing somthing?
from substrate-api-client.
Yes they would. Happy to submit a PR, but I first wanted to raise the discussion to see if you agree and would merge rhis
from substrate-api-client.
I also gave it some more thought. In general I find the current separation into expected and unexpected status quite arbitrary. Whether they are expected or not depends on the use case and I feel that by making this separation we make a decision that actually the user should take.
In polkadot there is a is_final
method: https://github.com/paritytech/polkadot-sdk/blob/74a42cebc1a9fd4e4a7713d5e41caba77a0fa172/substrate/client/transaction-pool/api/src/lib.rs#L161
Maybe we should also use this in our methods. You can wait for some status but once we receive a final status we stop waiting. What do you think?
from substrate-api-client.
That sounds better than my hack commits
from substrate-api-client.
Ok, I will try to come up with a PR. Still need to do some thinking on how to do this. This change could lead to some very subtle breaks of backward compatibility for clients.
from substrate-api-client.
Related Issues (20)
- release-polkadot-v1.7.0
- release-polkadot-v1.7.2
- release-polkadot-v1.8.0
- make stable build work for std
- implement `balance_transfer_keep_alive`
- release substrate-client-keystore to crates.io HOT 2
- Question: less crates on crates on crates.io HOT 1
- Error while subscribing transfer event HOT 6
- Investigate: Chainhead API
- Test/Example for WebAssembly HOT 3
- Nightly build HOT 1
- Investigate WebAssembly support for '-client' feature
- Refactor SubmitAndWatch trait
- Support Merkleized Metadata HOT 1
- Use substrate image, that is kept up-to-date HOT 1
- Incorporate stabilized APIs
- Fix failing build on master HOT 1
- Develop a strategy regarding backwards compatibility
- Activate disabled extrinsic tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from substrate-api-client.