Giter Club home page Giter Club logo

Comments (5)

elichai avatar elichai commented on May 24, 2024

Did you redo the PTT with the new address?
Core needs to get the key for the contract.

from enigma-core.

lacabra avatar lacabra commented on May 24, 2024
  • Did you redo the PTT with the new address?
    I don't control the PTT from the client side. In the integration tests I'm only dealing with the functionality that the Enigma.JS provides, and it's not part of the library to trigger or manage the PTT. The network should handle it automatically.

As far as I understand, the P2P subscribes to epoch changes, and that's the only time when it triggers PTT requests to/from core. @lenak25 and @fredfortier can confirm.

Shouldn't it be core 's responsibility to request keys if it realizes it's missing them for a deploy/compute request it receives? Because these requests come already validated by P2P that are indeed directed to that instance of core, so if at that point core is missing some state keys, shouldn't it do something about it?

cc:@moria

from enigma-core.

elichai avatar elichai commented on May 24, 2024

No. If there's a new contract in the middle of the epoch it should be the p2p responsibility to initiate a new PTT.
core has no sense of epochs etc.

from enigma-core.

lacabra avatar lacabra commented on May 24, 2024

Well, then I would like @lenak25 and @Isan-Rivkin to comment on this.

from enigma-core.

lacabra avatar lacabra commented on May 24, 2024

Similar to #113, I had misidentified this issue as well, and the underlying issue is in the P2P repo as reported here: GetStateKeys before deploying a contract

So closing this issue in favor of the issue reported in P2P.

from enigma-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.