Giter Club home page Giter Club logo

Comments (5)

moriaab avatar moriaab commented on May 28, 2024

@lacabra
To reproduce the behavior I need some clarifications:

  1. Does the valid contract have a constructor. It is better if you point me to the real contract.
  2. What is this: Fn='not a valid construct()' ? Is this a decrypted callable?
  3. Please give me the relevant inputs, at least callable and arguments

from enigma-core.

elichai avatar elichai commented on May 28, 2024

I think he meant the opposite, that he passed an invalid constructor and it didn't fail.

from enigma-core.

lacabra avatar lacabra commented on May 28, 2024

Correct, I passed an invalid constructor, and it didn't fail.
Take any contract, and pass the following:

Callable='whatever-you-want-here-that-is-not-a-valid-construct-function'
Args=[]

from enigma-core.

lacabra avatar lacabra commented on May 28, 2024

In the integration tests, run the following tests in this order:

  1. 01_init.spec.js
  2. 03_deploy_fail_constructor.spec.js

And the deployment does not fail as expected, but instead it succeeds.

from enigma-core.

moriaab avatar moriaab commented on May 28, 2024

This defect is planned to be fixed as part of general improvement of treating wrong inputs for deployment and computation of secret contracts.

from enigma-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.