Giter Club home page Giter Club logo

Comments (5)

VMRuiz avatar VMRuiz commented on July 4, 2024

Hello, spidermon calculates coverage based on the fields existing on the item. If you are using a item class that always defines all their fields with some default value like None, "". Alternatively, items like dict and scrapy.Items should work fine.

from spidermon.

wRAR avatar wRAR commented on July 4, 2024

regardless of whether the item field is empty or not.

Yes, there is a difference between non-empty and non-existent, and coverage is calculated based on the latter.

from spidermon.

oyhel avatar oyhel commented on July 4, 2024

Thank you for the clarification. If I do not load the Item with the variable at all I still get no spidermon_item_scraped_count for the variable so I am a little unsure what is "triggering" these counts (since neither non-existent nor empty values seem to be counted). Could I bother you with briefly explaining what would be defined as 'non-existent' in this case? It would be very useful to have item coverage working...
Thanks!

from spidermon.

wRAR avatar wRAR commented on July 4, 2024

If I do not load the Item with the variable at all I still get no spidermon_item_scraped_count for the variable

Which is good?

I am a little unsure what is "triggering" these counts (since neither non-existent nor empty values seem to be counted).

Per your original report empty values were counted while non-existent ones were not, which is the expected behavior.

Could I bother you with briefly explaining what would be defined as 'non-existent' in this case?

Non-existent means the item doesn't have the field at all. Note that setting it to None is the same as not setting it at all, as None values are ignored by ItemLoader, not sure if it's related to your questions though.

from spidermon.

oyhel avatar oyhel commented on July 4, 2024

Thank you for the clarification, I got it working!

The thing was that my pipeline errored out with a key error if I did not specify a value. For this reason I was passing None values where the value were not found. Once I understood that instead of doing (in the pipeline)

thing.variable = item['variable']

I could do
thing.variable = item.get('variable')

The pipeline allowed non-existent values and the item coverage works as you describe.

from spidermon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.