Enhancement: Handle Google Sign-In Crashes about little_victories HOT 6 CLOSED

Hello @ScottishRoss

While I have doing with my own setup to this repo, my Google Sign-In process, doesn't the app crashes. It is working fine and when I saw this how this could be happen to others?

from little_victories.

Hi @devkishor8007, it is likely due to the setup being wrong (i.e. Google Auth not enabled on Firebase). I wasn't able to replicate it either, but during the investigation some improvements and fixes were made, so merged it as part of the issue.

This enhancement is about properly handling the error, in case it happens.

from little_victories.

I think, It will handle automatically in Firebase using google auth. At what case should we handle the error because when we tap to the button 'Continue with Google', it pops up and show the accounts as we tap the gmail account that goes to home screen. I personally feel #19 issue was the developer doesn't put SHA1 while setup the firebase where the app was crashes.

I face Canceling Google SignIn exception in this repo but This issue comes only resides in debug mode. If the user cancels the Google Sign In then the app won't freeze or crash in the release mode.

from little_victories.

I'll do some testing when I get a chance. It would still be good practice to handle a potential error.

from little_victories.

I'll do some testing when I get a chance. It would still be good practice to handle a potential error.

Sure, testing is good and handling a error is a wonderful things.

from little_victories.

This has been fixed with the correct Firebase SHA-1 keys. Enhancement to error logging will be a separate ticket.

from little_victories.