New Feature: Add Victory also includes icons about little_victories HOT 15 CLOSED

Can I work on this till my Twitter Dev account is being approved? @ScottishRoss

from little_victories.

I apologise for my bad drawing, but something like this:

But I'm thinking something like this, but for Icons:

from little_victories.

@sudo-saksham It's worth checking if this issue exists in Develop, or if it's in your branch and some changes need to be made. If there are any changes that happened to develop (some refactoring changes happened with Hacktoberfest), then it's a combination of those chances and yours, and it'll mean some changes need to be made on your branch.

Though, I am liking the look of the changes your making! It's looking good!

from little_victories.

I'll have s look tomorrow @sudo-saksham. Great work so far!

from little_victories.

Hey @ScottishRoss, in this issue when a user celebrates a victory then he should also get an emoji section to use in his celebration text, right?

from little_victories.

I'm thinking that the user should be able to select an icon that represents what they've done. Such as the icons suggested. These icons would display in the View_Victories list in the list tile to the left of the Victory. Here's an awful drawing of the idea:

from little_victories.

So, when should the user be able to select the icons, when they are creating a victory celebration card or when they have already created the card and then reacting with these in the View_Victory list?

from little_victories.

When they are creating the Victory, in that modal. Probably underneath the text field.

from little_victories.

Should I offer just the icon or text next to the icon as well in the add victory section? @ScottishRoss

from little_victories.

Did you change the design of Adding the victory dialog box to this image on purpose? Because it's creating a Pixel Overflow issue when keyboard opens. I'm attaching related image and video with this comment. @ScottishRoss

from little_victories.

Ooh that's interesting @sudo-saksham. That overflow issue doesn't happen for me. If you checkout the develop branch and have a look there, is that issue there?

from little_victories.

@ScottishRoss Are you referring to the occurence of this error in develop branch code or whether the this is registered as an issue?

from little_victories.

Can you look into the changes I made in this . I made some changes which you also minimizes this overflow issue. Though, the design might not be much good as I just changed to remove the error. I can work on design and refactoring next if you want. @ScottishRoss

from little_victories.

Then, I'll most probably start integrating Facebook login. Let me know if any change needs to be made. @ScottishRoss

from little_victories.

Handled in #37

from little_victories.