Giter Club home page Giter Club logo

Comments (5)

scoder avatar scoder commented on July 26, 2024

Sounds like a good idea.

from lupa.

dubois avatar dubois commented on July 26, 2024

I never got around to adding the patch :-P. Here it is!
https://gist.github.com/dubois/9478877

from lupa.

scoder avatar scoder commented on July 26, 2024

Thanks. A couple of comments:

  • looks very good functionality wise
  • lacks tests
  • I prefer pull requests :)
  • "richcmp()" is bidirectional, so you can't be sure the first argument is "self", it might be the second (which is, I guess, why you thought you'd have to type the first argument explicitly)
  • "uintptr_t" appears to be C99. Not sure I want to require that. There's also the "stdint.h not in MSVC" issue. Tricky ground.
  • the comparison operators should use the CPython constants (from cpython.object cimport Py_EQ, ...), not plain integers. There's also no need to explicitly return True/False, just return the comparison result.
  • there's a special type "Py_hash_t" that Cython defines as return value of "hash()" (and that it backports for Py<3.2)

from lupa.

SoulSen avatar SoulSen commented on July 26, 2024

I'm pretty sure this occurs with all _LuaObject, since I've experienced this with _LuaFunction too

from lupa.

scoder avatar scoder commented on July 26, 2024

Don't know why this was closed. Doesn't look like it's resolved.
PR welcome, as described above.

from lupa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.