Giter Club home page Giter Club logo

Comments (7)

sciurius avatar sciurius commented on August 21, 2024 1

Actually I'm mostly glad you brought this tool under my attention. Yes, I've been using it for more that 30 years and fiddled a bit to keep modern Perl satisfied but it is still mostly the same as 30 years ago. It may need a bit of cleaning up, mostly the files that go with it and make a 'new' (FWIW) release on Github and CPAN so it has a home (and well-defined state) again. I was aware of the Peaceware problem that's why I changed it to Artistic some time ago.

AFAIC you don't need to remove your repo. It clearly indicates that it is based on the original version.

I see no added benefits from perltydying so I'd prefer to leave the style as it is now. You know that every character modified may introduce new bugs ;). Besides, I think I've already made some style improvements with the Perl5 update.

One of the charming aspects of this program is that is is a single-file program. Modern Perl standards (since Perl5 -- 26 years ago) are module-oriented, so a real modernized tool would consist of at least one module (e.g. App::Dusage) and a script (script/dusage) to invoke it. While I'm not really in favour of this approach I do not mind going that direction. What do you think?

from dusage.

sciurius avatar sciurius commented on August 21, 2024 1

The modularity is mere cosmetic, since the current version requires Perl5 anyway. It won't run on Perl4 which is very extinct. Even older Perl5 versions should be avoided. Personally I lay the bar at 5.10.1 since that is the first version of the current generation of Perl5. It is also the first version to have decent Unicode support and it is the oldest version that I have on my system for testing. 5.10.1 went end of life on 2009-08-23.

An additional complication is that CPAN, where all Perl material ought to be, is still not script-friendly. A kit will not be published unless it has at least one module. It will be stored but will not enter the search engines. I must look into that.

I've checked in a Changes file.

from dusage.

sciurius avatar sciurius commented on August 21, 2024 1

Reworked some files and added some more. It is now a decent CPAN kit.

from dusage.

sciurius avatar sciurius commented on August 21, 2024 1

Hi Jeffrey,
I applied a selection of your changes to the master. I didn't incorporate all the new and fancy files and changes that I don't see a real use for.

I attributed the changes to you. Thanks for contributing and giving me the incentive to wipe the dust off :) .

from dusage.

johnsonjh avatar johnsonjh commented on August 21, 2024

Honestly, that's the really is no need for all that modularity in such a simple tool - also, perhaps someone somewhere still wants to run it on Perl 4 (or something) - anyway, I see no benefit.

I respect your view on the perltidy changes. I'm not a Perl user by any means (just a few tasks and one-liners here and there), so I'll respect your lead here.

I think I'll prepare a PR with what's needed for a "proper" GitHub release based on cloning your sources, adopting your change from Peaceware to Artistic licensing, and send you a PR sometime this week for you to review.

By any chance do you have a CONTRIBUTOR listing or ChangeLog of some kind? I don't think it's necessary to rewrite the repo's history, but it would be nice to include, if they are available.

from dusage.

johnsonjh avatar johnsonjh commented on August 21, 2024

Sorry, been busy with work this week, but I plan to update my repo to yours and give you a PR with an slightly expanded README - probably not much else to do. Thanks for the updates!

from dusage.

johnsonjh avatar johnsonjh commented on August 21, 2024

#2 as promised.

from dusage.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.