Comments (8)
It didn't have a backport label yeah, I've added it. This will have to wait for 1.13.1
though, and I'm not sure when that will be since the bandwidth requirements to get 1.13.0
out quickly were fairly high. We'll see how many complaints we get.
from scipy.
scipy/pocketfft#1 seems to populate the preprocessor "variable" in question for me locally on a newer MacOS (it was not getting defined properly before that patch). If we want the patch it may need to be applied upstream first, not sure, but anyway that may be worth trying...
from scipy.
looks like gh-20333 missed a backport @tylerjereddy ?
from scipy.
which version of OSX does it fail on?
from scipy.
10.9. we could bump to 10.13, but in either case the detection and preprocessor-guard is not working
from scipy.
@h-vetinari tried to sync in the small preprocessor directive patch to conda-forge
without success, so this issue should remain open and we should probably just disable the alloc thing completely then, as upstream did and NumPy likely will.
from scipy.
This still occurs with SciPy 1.13.0, with scipy/pocketfft@0bf2b51, because the submodule in scipy hasn't been updated to incorporate scipy/pocketfft#3 yet.
[880/1475] Compiling C++ object scipy/fft/_pocketfft/pypocketfft.cpython-310-darwin.so.p/pypocketfft.cxx.o
FAILED: scipy/fft/_pocketfft/pypocketfft.cpython-310-darwin.so.p/pypocketfft.cxx.o
x86_64-apple-darwin13.4.0-clang++ -Iscipy/fft/_pocketfft/pypocketfft.cpython-310-darwin.so.p -Iscipy/fft/_pocketfft -I../scipy/fft/_pocketfft -I../scipy/_lib/pocketfft -I$PREFIX/include -I$PREFIX/include/python3.10 -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -DNDEBUG -Wall -Winvalid-pch -std=c++17 -O3 -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/scipy-split-1.13.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.9 -DPOCKETFFT_PTHREADS -DPOCKETFFT_CACHE_SIZE=16 -MD -MQ scipy/fft/_pocketfft/pypocketfft.cpython-310-darwin.so.p/pypocketfft.cxx.o -MF scipy/fft/_pocketfft/pypocketfft.cpython-310-darwin.so.p/pypocketfft.cxx.o.d -o scipy/fft/_pocketfft/pypocketfft.cpython-310-darwin.so.p/pypocketfft.cxx.o -c ../scipy/fft/_pocketfft/pypocketfft.cxx
In file included from ../scipy/fft/_pocketfft/pypocketfft.cxx:19:
../scipy/_lib/pocketfft/pocketfft_hdronly.h:163:15: error: no member named 'aligned_alloc' in the global namespace; did you mean simply 'aligned_alloc'?
void *ptr = ::aligned_alloc(align,(size+align-1)&(~(align-1)));
^~~~~~~~~~~~~~~
aligned_alloc
../scipy/_lib/pocketfft/pocketfft_hdronly.h:160:14: note: 'aligned_alloc' declared here
inline void *aligned_alloc(size_t align, size_t size)
^
1 error generated.
from scipy.
The fix in conda-forge is to simply pull in scipy/pocketfft@9367142, but this should still be fixed on the 1.13 branch
from scipy.
Related Issues (20)
- MAINT, DOC: JupyterLite build fails via "make dist" on release branch HOT 11
- MAINT: special version hex cleanup HOT 2
- BUG: scipy.stats.kstest returns NaN starting in scipy 1.12 HOT 8
- BUG: Problems with new scipy 1.13 RegularGridInterpolator spline interpolation beyond documented behaviour HOT 4
- DOC: Version switcher is not vertically centred on mobile HOT 2
- BUG: `sparse.hstack` does not respect `dtype` of `{indptr,indices}` but `sparse.vstack` does for `csr` (and vice-versa for `csc`)
- DOC: optimize.root(method='lm') option HOT 1
- BUG: unnecessary computations in iirpeak/iirnotch/iircomb filter gain could simplify to 1 HOT 1
- BUG: Segmentation Fault with scipy.linalg.expm When Importing torch on macOS HOT 2
- Licensing: proposed addition with an Apache 2.0 with LLVM runtime exception HOT 21
- BUG: scipy.special.logsumexp raises ValueError for a zero-size array
- BUG: fft.fftfreq appears to be giving wrong answers HOT 3
- BUG: <Unable to import 'triu' module> HOT 5
- BUG: scipy.optimize.linprog can not find the correct minimum value HOT 3
- DOC: the SciPy website mistakenly believe that the chi2_contingency function returns a Chi2ContingencyResult HOT 1
- ENH: signal: integrate new implementation of `remez` HOT 6
- Possible typo in computation of hypergeometric function 2F1 HOT 8
- scipy 1.12.0 building from source issue with cython 0.29.36 HOT 1
- BUG: csr_array can no longer be initialized with 1D array HOT 4
- BUG: nightly: .special.jv now promotes float32 inputs to float64 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scipy.