Giter Club home page Giter Club logo

Comments (17)

beyondmetis avatar beyondmetis commented on May 16, 2024

Sure, if this makes it easier to use, that would be great. Do we need to tag the latest code and release? I know a couple bug fixes have been implemented since the latest official version. Let me know how I can help.

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

Do we need to tag the latest code and release?

yes, I think it would be better. I still have to learn how conda-forge works, but I think it's quite straightforward.

By the way: on PyPi there seems to be a scikit-video (outdated) and a sk-video package (the current one): it would be nice to "merge" the two things and come up with a single, scikit-video package which follows the standard scikit naming scheme.

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

I contacted Alex, one of our contributers responsible for the merge process between scikit-video and sk-video, but I haven't heard from him in over a year.

In the meantime, I'll update the tag on sk-video.

Do we have to actively maintain the latest release on conda-forge? Or is this automatic?

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

Tag updated

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

Do we have to actively maintain the latest release on conda-forge? Or is this automatic?

no, versions on conda-forge must be manually bumped

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

as far as I understand, I think I need also the tar.gz source package on PyPi: is this possible? How do you manage the PyPi uploading? do you do it by hand?

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

I do it by running a console command, which builds the wheel and uploads the package to pypi. Let me see if I can build a source package.

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

Alright, it looks like the source build worked. Try it now?

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

ok I can see it, thanks. Now I need to prepare the conda recipe, it will take me some time to figure out the right setup. Probably I will bother you with other questions...

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

ok, I have staged a very basic recipe and the tests are green (see here. Since you are using a BSD license I think you should include the LICENSE file with the license full text.

Now we need to wait for the PR to be reviewed and included in the conda-feedstock. If you wish, (@beyondmetis) I can add you as a maintainer of the conda-feedstock as well.

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

ok @beyondmetis, thanks for uploading the license text. Can you re-upload the tar.gz including the LICENSE.txt file? Or are you forced to bump the version number?

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

I tried to re-upload the updated tar.gz file, but pypi never allows file replacement. I will bump the version and re-upload.

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

Version has been bumped with license file.

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

@beyondmetis package is now live on conda-forge, this is the link to the feedstock.

One possible quirk is the following: I have inserted the ffmpeg conda package among the build dependencies, which means that installing the package will automatically install also the ffmpeg package. On second thought, I'm quite sure that not all users want an automated install of the latter: e.g. a scenario where the user has his/her own ffmpeg installation or wants to use libav. Do you agree? Should I remove this dependency?

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

You can remove the ffmpeg dependency since skvideo checks for a working ffmpeg/libav install. Installing isn't totally automatic, but at the least the user will see the right error if the dependency is not met.

It looks like we will transition the sk-video package to scikit-video on pypi soon. We would probably update both pypi names for a period of time. How hard is it to update the conda package to point to scikit-video on pypi when this happens?

from scikit-video.

carlodri avatar carlodri commented on May 16, 2024

You can remove the ffmpeg dependency

done.

How hard is it to update the conda package to point to scikit-video on pypi when this happens?

no idea.... let's say that we can close this issue and we open another one when the transition starts happening. Agreed?

from scikit-video.

beyondmetis avatar beyondmetis commented on May 16, 2024

Agreed

from scikit-video.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.