Make sure pipenv-based development workflow works about pyhf HOT 7 CLOSED

hm -- maybe this is an issue with my local installation since that's exactly what we do in travis.

from pyhf.

Hm, this seems odd as pytest-benchmark[histogram] is in the developlist. I agree that we should make sure that everything is installed though with it.

from pyhf.

We can also see from Travis Build 366 that the benchmarks are getting run when a PR is merged into master, so it is being setup correctly by pip install -e .[develop] in the CI.

from pyhf.

@matthewfeickert I think the issue might be that we manually upgrade pytest in the travis file. If we need a specific version probably pip install should pick up the right one

concretely what happens for me is that with pipenv

pipenv install -e[develop]

it still picks up a pytest outside of the pipenv, and that pytest wil not be able to import dependencies installed in the virtualenv

from pyhf.

Ah okay. Sorry, I haven't been using pipenv so I haven't noticed this. Let me setup a new environment with it and see what is the minimum package versions to make things work.

from pyhf.

closing this can't even reproduce this locally :-p

from pyhf.

Ah okay, so all is working well then?

from pyhf.