General API parity between cms.style and atlas.style desirable about mplhep HOT 12 CLOSED

I agree. cms.style contains styling helpers I use specifically for CMS. I'd be happy to include equivalent functions for ATLAS, but I don't know what is typically needed.

from mplhep.

I don't understand what API parity means here. There's no special function for atlas styles specifically, other than importing and setting the mpl styles. I didn't use anything more to make our plots for the pyhf pub notes.

from mplhep.

Right now the only CMS specific part is the main plot label i.e. CMS Preliminary , which is a bit finicky to get right, which is why I outsourced it here. We could presumably do something similar for ATLAS.

from mplhep.

I don't understand what API parity means here.

Perhaps "consistency" is a better choice of words? I just mean that if you look at mplhep.cms.style and mplhep.atlas.style there are currently different in that the README shows that one must do

plt.style.use(hep.cms.style.ROOT)
plt.style.use(hep.atlas.style.ATLAS)

to use different styles. It would be nicer in my mind to have them be unified such that for the different experiments one would just do

plt.style.use(hep.<experiment>.style.ROOT)

from mplhep.

While I agree in general, as of now, we have only two styles. I am also not sure if there are meaningful differences between general ROOT and specific CMS (maybe figure aspect).

I also originally thought to have all styles unique, such that they can be called as hep.style.ATLAS or hard copied to mpl cache, but I'm happy to revise it.

from mplhep.

I also originally thought to have all styles unique, such that they can be called as hep.style.ATLAS

Fair. Whatever API you prefer is fine by me, just let me know, and we can go from there.

from mplhep.

@matthewfeickert @kratsg One obvious thing to generalize is the experiment label (hep.cms.cmslabel) could you post some examples/spec of the labelling typically used in ATLAS?

from mplhep.

atlas: &atlas
  x: 0.225
  y: 0.88
  font: 73
  size: 25
  label: ATLAS

internal: &internal
  x: 0.35
  font: 43
  label: Internal
  <<: *atlas

atlasinternal: &atlasinternal
  - *atlas
  - *internal

used in this code: https://github.com/kratsg/TakeOverTheWorld/blob/989c97382689d77649bdf29e00f10d509a6c7b90/totw.py#L413-L421

          # attach the label
          label = ROOT.TLatex(text['x'], text['y'], text['label'])
          label.SetTextFont(text['font'])
          label.SetTextSize(text['size'])
          label.SetNDC()
          label.Draw()

Internal is replaced with Simulation, Preliminary, etc... as needed.

from mplhep.

So really pretty much the same as for CMS right?

from mplhep.

So really pretty much the same as for CMS right?

It should be. we should build the generic addExperimentLabel function and then an addATLASLabel / addCMSLabel.

from mplhep.

#39 should add atlas options

hep.atlas.atlastext()
hep.atlas.atlaslabel().

I'm open to better names

from mplhep.

@matthewfeickert @kratsg anything else or can I close this?

from mplhep.