Giter Club home page Giter Club logo

Comments (3)

jpivarski avatar jpivarski commented on June 14, 2024

This is actually an issue in uproot-methods, since it deals with physics calculations. I've opened a PR on that repo: scikit-hep/uproot3-methods#43, but I'm not entirely sure if this fixes the problem because I don't have good test cases. (When I make up values of 4-vectors, I get NaN because they weren't realistic 4-vectors that are within light cones.)

Could you give that a test? Thanks!

from awkward-0.x.

beojan avatar beojan commented on June 14, 2024

You could use setptetaphim to generate four vectors

from awkward-0.x.

jpivarski avatar jpivarski commented on June 14, 2024

I used TLorentzVectorArray.from_ptetaphim, but I didn't think too hard about the numbers I put in it.

If I don't hear from you today about the correctness of the calculation, I'll take that pull request and leave everything else the same.

(The pull request itself fixes an issue unrelated to the calculation of boost: it's that TLorentzVectors, projected to TVector3s, incorrectly kept their identities as TLorentzVectors and then there was an attempt to add some TVector3s and some supposed TLorentzVectors, which would be wrong if that's what they actually were.)

from awkward-0.x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.