[Enhancement] Release GIL about scikit-fmm HOT 3 OPEN

Here is a quick thought on this: all the calculation is done in C++ where we can multithread without releasing the GIL. We could make a new entry point on the Python side that can take several input arrays and process them simultaneously. This is a compromise that does not give full flexibility but is safer on the Python side. Would this suit your use case?

(With the limited time I have available I am going to focus on getting an update out that adds 3.12 compatibility and I want to work on the higher order narrowband initialization.)

from scikit-fmm.

Hi Jason,

that proposition would change the API and is not a drop-in to the existing implementation.
Can I go ahead and pitch a PR for the write flag on the array?

Best,
M

from scikit-fmm.

@jkfurtney if this is too hacky, we can (1) introduce a second method with the same signature which is releasing the GIL for the computation.

Or (2) introduce a keyword to release the GIL.

Both options are backwards compatible.

What do you think?

from scikit-fmm.