Giter Club home page Giter Club logo

Comments (2)

henryiii avatar henryiii commented on May 26, 2024

It looks like the logic is incorrect for passing this through properly. It was only designed for setup.py commands. :( I think

scikit-build/skbuild/setuptools_wrap.py

Lines 114 to 115 in 676e110

if namespace.build_type is not None:
_cmake_args.append("-DCMAKE_BUILD_TYPE:STRING=" + namespace.build_type)
needs to respect having it already set in the arguments, like

scikit-build/skbuild/setuptools_wrap.py

Lines 600 to 607 in 676e110

# Select correct --config using final CMAKE_BUILD_TYPE
for item in cmake_args[::-1]:
if item.startswith("-DCMAKE_BUILD_TYPE"):
_, config_type = item.split("=")
break
else:
config_type = "Release"
cmake_args.append("-DCMAKE_BUILD_TYPE:STRING=Release")
does.

PS: In scikit-build-core you can set this in toml or via -C (config-settings).

from scikit-build.

qnzhou avatar qnzhou commented on May 26, 2024

Thanks! I will try scikit-build-core again. I remember there was some missing feature (possibly related to editable debug build) that prevents me from migrating to it, but I will double check again! Thanks for confirming this bug!

from scikit-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.