Giter Club home page Giter Club logo

Comments (8)

schwamster avatar schwamster commented on June 16, 2024 1

ah snap... now i understand what the problem is :)
copy paste bug

will fix it asap! thanks for pointing it out

from serverless-certificate-creator.

schwamster avatar schwamster commented on June 16, 2024

@Vad1mo I am not sure if I understand the problem. Did you create your domain and the certificate yourself?

from serverless-certificate-creator.

schwamster avatar schwamster commented on June 16, 2024

@Vad1mo fyi: the domain plugin is not mutually exclusive with cloudformation, terraform or any other mean of creating your a-records. the domain plugin can simply be used to create the necessary base path mapping with an already existing domain. => https://github.com/amplify-education/serverless-domain-manager (hint: look at the property table: createRoute53Record)

from serverless-certificate-creator.

Vad1mo avatar Vad1mo commented on June 16, 2024

To create the cert I am using serverless-certificate-creator, for the domain we have already a hosted zone. There need to be a subdomain or an alias on the root domain to be created.

I can't use the serverless-domain-manager as the plugin attaches the domain to the api gateway. We are using lambda@edge and need to attach the domain to cloudfront. See amplify-education/serverless-domain-manager#163. So if I don't use the plugin serverless-domain-manager I get the error message as seen above.

from serverless-certificate-creator.

schwamster avatar schwamster commented on June 16, 2024

can you tell me how your custom/customCertificate serverless config looks like (please without sensitive data )

from serverless-certificate-creator.

Vad1mo avatar Vad1mo commented on June 16, 2024

Here is the config I am using.

....
plugins:
  - serverless-plugin-cloudfront-lambda-edge
  - serverless-finch
  - serverless-certificate-creator

custom:
  defaultRegion: us-east-1
  defaultEnvironmentGroup: dev
  region: ${opt:region, self:custom.defaultRegion}
  stage: ${opt:stage, 'poc'}
  objectPrefix: '${self:service}-${self:custom.stage}'
  client:
    bucketName: '${self:custom.objectPrefix}'
    distributionFolder: website/
  customCertificate:
    certificateName: 'docs.sandbox.com'
    hostedZoneName: 'sandbox.com.'
    region: ${self:custom.region}
  customDomain:
    enabled: true
....

As you see the

customDomain:
    enabled: true

part is there if not existent I get the above error.

from serverless-certificate-creator.

schwamster avatar schwamster commented on June 16, 2024

just published 1.0.4 => https://www.npmjs.com/package/serverless-certificate-creator/v/1.0.4
@Vad1mo can you verify that it works for you?

from serverless-certificate-creator.

Vad1mo avatar Vad1mo commented on June 16, 2024

Works great thank you. ❤️

from serverless-certificate-creator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.