Comments (2)
schwamster
commented on June 8, 2024
thanks for the input and sorry for the late reply. This behaviour is (was) desired. At least I thought it was. The reason it is implemented like that, is to save this extra calls every time you update your lambda since the certificate creation is usually something you only do once. If the creation fails it actually fails the deployment. Problem is, it does not clean up the already created but not yet validated certificate. So in the case of failure it forces you to remove the created certificate and rerun everything (or add the validation records manually).
I get your point and it is most likely not all that expensive to do it. Could you provide a PR for this?
from serverless-certificate-creator.
commented on June 8, 2024
No worries! I may not be able to get to a PR for a while but I'll definitely leave this issue open in case anyone else wants to take it on sooner than that.
from serverless-certificate-creator.
Related Issues (20)
- Exisiting domains and records prevent creation of new Certificates HOT 1
- Error: Request contains invalid set of changes for resource record set CNAME HOT 2
- add enable config flag HOT 1
- version 1.5.0 is broken HOT 3
- Plugin is throwing "TypeError: Cannot read property 'enabled' of undefined" errors HOT 1
- Broken on sls 2.30.0 (works on 2.29.0) HOT 2
- When looking for existing certificates, plugin lists only first 100 certs HOT 1
- Version 1.5.2 incompatible with serverless >= 2.31 HOT 1
- wildcard and basename certificates fails to create route53 record HOT 2
- Creating multiple certificates for different regions HOT 4
- Clean up route53 post certificate validation
- "TypeError: Cannot read property 'options' of undefined" with Serverless >= 2.38.0 HOT 1
- TypeError: Cannot read property 'Name' of undefined
- variablesResolutionMode: 20210326 - no hosted zone for domain found HOT 2
- will fail to find a domain by name if it includes uppercase letters
- autoCertificate to use with autoDomain in serverless-domain-manager plugin?
- Export ARN HOT 1
- create-cert command no longer functional with @serverless/compose HOT 1
- option --conceal not found
- Route53 client instantiation doesn't include region
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serverless-certificate-creator.